Skip to content

Commit 69e4772

Browse files
committed
Make running status methods private
They are meant to be used only by the dispatch actor. Signed-off-by: Mathias L. Baumann <[email protected]>
1 parent dd42670 commit 69e4772

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/frequenz/dispatch/_dispatch.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,20 @@ def __init__(
8383
running_state_change_synced,
8484
)
8585

86-
def set_deleted(self) -> None:
86+
def _set_deleted(self) -> None:
8787
"""Mark the dispatch as deleted."""
8888
object.__setattr__(self, "deleted", True)
8989

90-
def running_status_notified(self) -> bool:
90+
@property
91+
def _running_status_notified(self) -> bool:
9192
"""Check that the latest running state change notification was sent.
9293
9394
Returns:
9495
True if the latest running state change notification was sent, False otherwise.
9596
"""
9697
return self.running_state_change_synced == self.update_time
9798

98-
def set_running_status_notified(self) -> None:
99+
def _set_running_status_notified(self) -> None:
99100
"""Mark the latest running state change notification as sent."""
100101
object.__setattr__(self, "running_state_change_synced", self.update_time)
101102

src/frequenz/dispatch/actor.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ async def _fetch(self) -> None:
119119

120120
for dispatch in old_dispatches.values():
121121
_logger.info("Deleted dispatch: %s", dispatch)
122-
dispatch.set_deleted()
122+
dispatch._set_deleted()
123123
await self._lifecycle_updates_sender.send(Deleted(dispatch=dispatch))
124124
if task := self._scheduled.pop(dispatch.id, None):
125125
task.cancel()
@@ -214,7 +214,7 @@ def _running_state_change(
214214
assert updated_dispatch is not None
215215

216216
# Client was not informed about the dispatch, do it now
217-
if not updated_dispatch.running_status_notified():
217+
if not updated_dispatch._running_status_notified():
218218
return True
219219

220220
# Deleted dispatch
@@ -252,4 +252,4 @@ async def _send_running_state_change(self, dispatch: Dispatch) -> None:
252252
await self._running_state_change_sender.send(dispatch)
253253
# Update the last sent notification time
254254
# so we know if this change was already sent
255-
dispatch.set_running_status_notified()
255+
dispatch._set_running_status_notified()

0 commit comments

Comments
 (0)