Changes to make the code more readable #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

foxbenjaminfox merged 4 commits into foxbenjaminfox:master from eladFrizi:master

Mar 1, 2019

Contributor

eladFrizi commented Feb 22, 2019 •

edited

Loading

I made changes to make the code in the install method more readable.

I moved the shouldUpdate logic into a separate module.
Moved the code that inits the data (in beforeCreate) with async computed into a function.
Moved the code that registers to the promises and updates the data into a function (in created).
The creation of the '$asyncComputed' in a more straight forward way.

eladFrizi added 4 commits

February 22, 2019 21:52


          moved should update logic into spreate module

e2aa217


          extarct the initialization of the data in beforeCreate into function

a4bb765


          creation of is now on the mixin's computed instead inside beforeCreate

275b410


          extract the handling (upadting and registration to promising) of asyn…

b26bc09

…c computed changes into function

foxbenjaminfox merged commit 8a576ec into foxbenjaminfox:master

Owner

foxbenjaminfox commented Mar 1, 2019

Thanks! This helps, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet