Auto merge of #119871 - nnethercote:overhaul-treat-err-as-bug, r=compiler-errors

Overhaul `-Ztreat-err-as-bug`

It's current behaviour is surprising, in a bad way. This also makes the implementation more complex than it needs to be.

r? `@oli-obk`

Author: bors