tests: removed test_main

Running the whole Firecracker main function in a unit test kind
of defeats the purpose of unit tests. It's extensively tested
in the integration tests, and causes unit test pain because of
the seccomp filters it installs (and maintains across the whole
suite).

Signed-off-by: Alexandra Iordache <[email protected]>

Author: Alexandra Iordache

src/main.rs

@@ -374,114 +374,3 @@ fn vmm_control_event(
     };
     Ok(())
 }
-
-#[cfg(test)]
-mod tests {
-    extern crate tempfile;
-
-    use self::tempfile::NamedTempFile;
-    use super::*;
-
-    use logger::AppInfo;
-    use std::fs::File;
-    use std::io::BufRead;
-    use std::io::BufReader;
-    use std::path::Path;
-    use std::time::Duration;
-    use std::{fs, thread};
-
-    /// Look through the log for lines that match expectations.
-    /// expectations is a list of tuples of words we're looking for.
-    /// A tuple matches a line if all the words in the tuple can be found on that line.
-    /// For this test to pass, every tuple must match at least one line.
-    fn validate_backtrace(
-        log_path: &str,
-        expectations: &[(&'static str, &'static str, &'static str)],
-    ) -> bool {
-        let f = File::open(log_path).unwrap();
-        let reader = BufReader::new(f);
-        let mut expectation_iter = expectations.iter();
-        let mut expected_words = expectation_iter.next().unwrap();
-
-        for ln_res in reader.lines() {
-            let line = ln_res.unwrap();
-            if !(line.contains(expected_words.0)
-                && line.contains(expected_words.1)
-                && line.contains(expected_words.2))
-            {
-                continue;
-            }
-            if let Some(w) = expectation_iter.next() {
-                expected_words = w;
-                continue;
-            }
-            return true;
-        }
-        false
-    }
-
-    #[test]
-    fn test_main() {
-        const FIRECRACKER_INIT_TIMEOUT_MILLIS: u64 = 150;
-
-        // If the default api socket path exist, remove it so we can continue running the test.
-        if Path::new(DEFAULT_API_SOCK_PATH).exists() {
-            fs::remove_file(DEFAULT_API_SOCK_PATH).expect("failure in removing socket file");
-        }
-
-        let log_file_temp =
-            NamedTempFile::new().expect("Failed to create temporary output logging file.");
-        let metrics_file_temp =
-            NamedTempFile::new().expect("Failed to create temporary metrics logging file.");
-        let log_file = String::from(log_file_temp.path().to_path_buf().to_str().unwrap());
-
-        // Start Firecracker in a separate thread
-        thread::spawn(|| {
-            main();
-        });
-
-        // Wait around for a bit, so Firecracker has time to initialize and create the
-        // API socket.
-        thread::sleep(Duration::from_millis(FIRECRACKER_INIT_TIMEOUT_MILLIS));
-
-        // If Firecracker hasn't finished initializing yet, something is really wrong!
-        assert!(Path::new(DEFAULT_API_SOCK_PATH).exists());
-
-        // Initialize the logger
-        LOGGER
-            .init(
-                &AppInfo::new("Firecracker", "1.0"),
-                Box::new(log_file_temp),
-                Box::new(metrics_file_temp),
-            )
-            .expect("Could not initialize logger.");
-
-        // Cause some controlled panic and see if a backtrace shows up in the log,
-        // as it's supposed to.
-        let _ = panic::catch_unwind(|| {
-            panic!("Oh, noes!");
-        });
-
-        // Before checking the backtrace let's remove the API socket to make sure we don't
-        // leave it on the host in case the assert fails.
-        fs::remove_file(DEFAULT_API_SOCK_PATH).expect("failure in removing socket file");
-
-        // Look for the expected backtrace inside the log
-        let backtrace_check_result = validate_backtrace(
-            log_file.as_str(),
-            &[
-                // Lines containing these words should have appeared in the log, in this order
-                ("ERROR", "main.rs", "Firecracker panicked at"),
-                ("ERROR", "main.rs", "stack backtrace:"),
-                ("0:", "0x", "firecracker::main::"),
-            ],
-        );
-
-        // Since here we have bound `stderr` to a file as a result of initializing the logger,
-        // we need to output debugging info on test failure to `stdout` instead.
-        if !backtrace_check_result {
-            println!("Could not validate backtrace!\n {:?}", Backtrace::new());
-            panic!();
-        }
-    }
-}

tests/integration_tests/build/test_coverage.py

@@ -19,7 +19,7 @@
 
 import host_tools.cargo_build as host  # pylint: disable=import-error
 
-COVERAGE_TARGET_PCT = 85.8
+COVERAGE_TARGET_PCT = 85.0
 COVERAGE_MAX_DELTA = 0.01
 
 CARGO_KCOV_REL_PATH = os.path.join(host.CARGO_BUILD_REL_PATH, 'kcov')