[vm_memory] remove unused methods

Signed-off-by: Serban Iorga <[email protected]>

Author: Serban Iorga

src/vm-memory/src/mmap.rs

@@ -339,27 +339,15 @@ impl GuestMemoryRegion for GuestRegionMmap {
         self.mapping.file_offset()
     }
 
-    // TODO: This implementation is temporary.
-    // We need to return None here once we refactor vsock.
     unsafe fn as_slice(&self) -> Option<&[u8]> {
-        // This is safe because we mapped the area at addr ourselves, so this slice will not
-        // overflow. However, it is possible to alias.
-        Some(std::slice::from_raw_parts(
-            self.mapping.as_ptr(),
-            self.mapping.size(),
-        ))
+        // We don't use this method.
+        None
     }
 
-    // TODO: This implementation is temporary.
-    // We need to return None here once we refactor vsock.
     #[allow(clippy::mut_from_ref)]
     unsafe fn as_mut_slice(&self) -> Option<&mut [u8]> {
-        // This is safe because we mapped the area at addr ourselves, so this slice will not
-        // overflow. However, it is possible to alias.
-        Some(std::slice::from_raw_parts_mut(
-            self.mapping.as_ptr(),
-            self.mapping.size(),
-        ))
+        // We don't use this method.
+        None
     }
 
     fn get_host_address(&self, addr: MemoryRegionAddress) -> guest_memory::Result<*mut u8> {
@@ -370,15 +358,13 @@ impl GuestMemoryRegion for GuestRegionMmap {
             .map(|addr| self.as_ptr().wrapping_offset(addr.raw_value() as isize))
     }
 
-    // TODO: This implementation is temporary.
-    // We need to return None here once we refactor vsock.
     fn get_slice(
         &self,
-        offset: MemoryRegionAddress,
-        count: usize,
+        _offset: MemoryRegionAddress,
+        _count: usize,
     ) -> guest_memory::Result<VolatileSlice> {
-        let slice = self.mapping.get_slice(offset.raw_value() as usize, count)?;
-        Ok(slice)
+        // We don't use this method.
+        Err(guest_memory::Error::HostAddressNotAvailable)
     }
 
     fn as_volatile_slice(&self) -> guest_memory::Result<VolatileSlice> {

tests/integration_tests/build/test_binary_size.py

@@ -21,7 +21,7 @@
     "aarch64": {
         "FC_BINARY_SIZE_TARGET": 2024744,
         "JAILER_BINARY_SIZE_TARGET": 1338312,
-        "FC_BINARY_SIZE_LIMIT": 2030000,
+        "FC_BINARY_SIZE_LIMIT": 2070000,
         "JAILER_BINARY_SIZE_LIMIT": 1511488,
     }
 }

tests/integration_tests/build/test_coverage.py

@@ -24,7 +24,7 @@
 # this contains the frequency while on AMD it does not.
 # Checkout the cpuid crate. In the future other
 # differences may appear.
-COVERAGE_DICT = {"Intel": 85.42, "AMD": 84.84, "ARM": 83.74}
+COVERAGE_DICT = {"Intel": 85.42, "AMD": 84.84, "ARM": 83.63}
 
 PROC_MODEL = proc.proc_type()