Fixes based on comments

Author: chronologos

auth-next/oidc.js

@@ -17,6 +17,8 @@ function oidcSignInPopup(provider) {
   signInWithPopup(auth, provider)
     .then((result) => {
       // User is signed in.
+      credential = OAuthProvider.credentialFromResult(result);
+      // This gives you an access token for the OIDC provider. You can use it to directly interact with that provider
     }).catch((error) => {
       // Handle Errors here.
       const errorCode = error.code;
@@ -25,6 +27,7 @@ function oidcSignInPopup(provider) {
       const email = error.email;
       // The AuthCredential type that was used.
       const credential = OAuthProvider.credentialFromError(error);
+      // Handle / display error.
       // ...
     });
   // [END auth_oidc_signin_popup]
@@ -46,8 +49,9 @@ function oidcSignInRedirectResult(provider) {
   const auth = getAuth();
   getRedirectResult(auth)
     .then((result) => {
+      // User is signed in.
       credential = OAuthProvider.credentialFromResult(result);
-      // ...
+      // This gives you an access token for the OIDC provider. You can use it to directly interact with that provider
     })
     .catch((error) => {
       // Handle Errors here.
@@ -57,8 +61,7 @@ function oidcSignInRedirectResult(provider) {
       const email = error.email;
       // The AuthCredential type that was used.
       const credential = OAuthProvider.credentialFromError(error);
-      console.log(error);
-      console.log(credential);
+      // Handle / display error.
       // ...
     });
   // [END auth_oidc_signin_redirect_result]
@@ -74,8 +77,9 @@ function oidcDirectSignIn(provider, oidcIdToken) {
   })
   signInWithCredential(auth, credential)
     .then((result) => {
+      // User is signed in.
       credential = OAuthProvider.credentialFromResult(result);
-      // ...
+      // This gives you a new access token for the OIDC provider. You can use it to directly interact with that provider.
     })
     .catch((error) => {
       // Handle Errors here.
@@ -85,8 +89,7 @@ function oidcDirectSignIn(provider, oidcIdToken) {
       const email = error.email;
       // The AuthCredential type that was used.
       const credential = OAuthProvider.credentialFromError(error);
-      console.log(error);
-      console.log(credential);
+      // Handle / display error.
       // ...
     });
   // [END auth_oidc_direct_sign_in]

auth-next/saml.js

@@ -17,6 +17,8 @@ function samlSignInPopup(provider) {
   signInWithPopup(auth, provider)
     .then((result) => {
       // User is signed in.
+      // Provider data available from the result.user.getIdToken()
+      // or from result.user.providerData
     }).catch((error) => {
       // Handle Errors here.
       const errorCode = error.code;
@@ -25,6 +27,7 @@ function samlSignInPopup(provider) {
       const email = error.email;
       // The AuthCredential type that was used.
       const credential = SAMLAuthProvider.credentialFromError(error);
+      // Handle / display error.
       // ...
     });
   // [END auth_saml_signin_popup]
@@ -46,8 +49,9 @@ function samlSignInRedirectResult(provider) {
   const auth = getAuth();
   getRedirectResult(auth)
     .then((result) => {
-      credential = SAMLAuthProvider.credentialFromResult(result);
-      // ...
+      // User is signed in.
+      // Provider data available from the result.user.getIdToken()
+      // or from result.user.providerData
     })
     .catch((error) => {
       // Handle Errors here.
@@ -57,8 +61,7 @@ function samlSignInRedirectResult(provider) {
       const email = error.email;
       // The AuthCredential type that was used.
       const credential = SAMLAuthProvider.credentialFromError(error);
-      console.log(error);
-      console.log(credential);
+      // Handle / display error.
       // ...
     });
   // [END auth_saml_signin_redirect_result]

auth/oidc.js

@@ -11,6 +11,7 @@ function oidcSignInPopup(provider) {
   // [START auth_oidc_signin_popup]
   firebase.auth().signInWithPopup(provider)
     .then((result) => {
+      // User is signed in.
       // result.credential is a firebase.auth.OAuthCredential object.
       // result.credential.providerId is equal to 'oidc.myProvider'.
       // result.credential.idToken is the OIDC provider's ID token.
@@ -34,12 +35,14 @@ function oidcSignInRedirectResult(provider) {
   // On return.
   firebase.auth().getRedirectResult()
     .then((result) => {
+      // User is signed in.
       // result.credential is a firebase.auth.OAuthCredential object.
       // result.credential.providerId is equal to 'oidc.myProvider'.
       // result.credential.idToken is the OIDC provider's ID token.
     })
     .catch((error) => {
-      // Handle error.
+      // Handle / display error.
+      // ...
     });
   // [END auth_oidc_signin_redirect_result]
 }
@@ -50,10 +53,12 @@ function oidcDirectSignIn(provider, oidcIdToken) {
 
   firebase.auth().signInWithCredential(credential)
     .then((result) => {
-      // user now has a odic.myProvider UserInfo in providerData.
+      // User is signed in.
+      // User now has a odic.myProvider UserInfo in providerData.
     })
     .catch((error) => {
-      // Handle error.
+      // Handle / display error.
+      // ...
     });
   // [END auth_oidc_direct_sign_in]
 }

auth/saml.js

@@ -19,7 +19,8 @@ function samlSignInPopup(provider) {
       // idTokenResult.claims.firebase.sign_in_attributes.
     })
     .catch((error) => {
-      // Handle error.
+      // Handle / display error.
+      // ...
     });
   // [END auth_saml_signin_popup]
 }
@@ -41,8 +42,9 @@ function samlSignInRedirectResult(provider) {
       // This is also available from result.user.getIdTokenResult()
       // idTokenResult.claims.firebase.sign_in_attributes.
     }).catch((error) => {
-      // Handle error.
-    });    
-    // [END auth_saml_signin_redirect_result]
+      // Handle / display error.
+      // ...
+    });
+  // [END auth_saml_signin_redirect_result]
 }