Skip to content

Commit 936a80b

Browse files
fix: hash routing incompatibility with email link (#870)
Documents hash routing incompatibility with email link sign in. Fixes #537
1 parent 6304ef0 commit 936a80b

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

README.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,14 @@ ui.start('#firebaseui-auth-container', {
10741074
// Additional state showPromo=1234 can be retrieved from URL on
10751075
// sign-in completion in signInSuccess callback by checking
10761076
// window.location.href.
1077+
// If you are using a fragment in the URL, additional FirebaseUI
1078+
// parameters will be appended to the query string component instead
1079+
// of the fragment.
1080+
// So for a url: https://www.example.com/#/signin
1081+
// The completion URL will take the form:
1082+
// https://www.example.com/?uid_sid=xyz&ui_sd=0#/signin
1083+
// This should be taken into account when using frameworks with "hash
1084+
// routing".
10771085
url: 'https://www.example.com/completeSignIn?showPromo=1234',
10781086
// Custom FDL domain.
10791087
dynamicLinkDomain: 'example.page.link',
@@ -1117,6 +1125,12 @@ if (firebase.auth().isSignInWithEmailLink(window.location.href)) {
11171125
Additional state passed in the <code>url</code> can be retrieved on sign-in
11181126
completion via the signInSuccess callbacks.
11191127

1128+
If you are using a fragment in the URL, additional FirebaseUI parameters will be
1129+
appended to the query string component instead of the fragment.
1130+
So for a url `https://www.example.com/#/signin`, the completion URL will take
1131+
the form `https://www.example.com/?uid_sid=xyz&ui_sd=0#/signin`.
1132+
This should be taken into account when using frameworks with "hash routing".
1133+
11201134
```javascript
11211135
// ...
11221136
signInSuccessWithAuthResult: function(authResult, redirectUrl) {

0 commit comments

Comments
 (0)