Skip to content

Commit fd879c2

Browse files
authored
Added secret manager API enablement on ext:install (#5702)
1 parent d1244ee commit fd879c2

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@
77
- firestore:locations
88
- Adds `extensions` as an option in `firebase init`.
99
- Relaxed repo URI validation in ext:dev:publish (#5698).
10+
- Added Secret Manager API enablement during ext:install for extensions that use secrets (#5702).

src/commands/ext-install.ts

+5
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { getProjectId, needProjectId } from "../projectUtils";
1111
import * as extensionsApi from "../extensions/extensionsApi";
1212
import { ExtensionVersion, ExtensionSource } from "../extensions/types";
1313
import * as refs from "../extensions/refs";
14+
import * as secretsUtils from "../extensions/secretsUtils";
1415
import { displayWarningPrompts } from "../extensions/warnings";
1516
import * as paramHelper from "../extensions/paramHelper";
1617
import {
@@ -197,6 +198,10 @@ async function installToManifest(options: InstallExtensionOptions): Promise<void
197198
);
198199
}
199200

201+
if (secretsUtils.usesSecrets(spec)) {
202+
await secretsUtils.ensureSecretManagerApiEnabled(options);
203+
}
204+
200205
const config = manifest.loadConfig(options);
201206

202207
let instanceId = spec.name;

0 commit comments

Comments
 (0)