From f62a2a2766579574df663c996bbb1e764f1f6363 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Wed, 28 Jun 2023 11:43:52 -0400 Subject: [PATCH 1/2] transactions.test.ts: increase the timeout of some tests to reduce flakiness --- packages/firestore/test/integration/api/transactions.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firestore/test/integration/api/transactions.test.ts b/packages/firestore/test/integration/api/transactions.test.ts index df7e520fccd..802dfdd0bbe 100644 --- a/packages/firestore/test/integration/api/transactions.test.ts +++ b/packages/firestore/test/integration/api/transactions.test.ts @@ -314,7 +314,7 @@ apiDescribe('Database transactions', (persistence: boolean) => { .run(get, set1, set2) .expectDoc({ foo: 'bar2' }); }); - }); + }).timeout(10000); // This test is identical to the test above, except that withNonexistentDoc() // is replaced by withDeletedDoc(), to guard against regression of @@ -355,7 +355,7 @@ apiDescribe('Database transactions', (persistence: boolean) => { .expectDoc({ foo: 'bar2' }); await tt.withDeletedDoc().run(get, set1, set2).expectDoc({ foo: 'bar2' }); }); - }); + }).timeout(10000); it('runs transactions on existing document', async () => { return withTestDb(persistence, async db => { From 5cc825d3a0034a52f854221fb088b546e7d36703 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 29 Jun 2023 02:16:47 -0400 Subject: [PATCH 2/2] Increase the timeouts in firestore/compat tests as well --- packages/firestore-compat/test/transactions.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firestore-compat/test/transactions.test.ts b/packages/firestore-compat/test/transactions.test.ts index 0109ea62f93..7a67e84e0e2 100644 --- a/packages/firestore-compat/test/transactions.test.ts +++ b/packages/firestore-compat/test/transactions.test.ts @@ -241,7 +241,7 @@ apiDescribe('Database transactions', (persistence: boolean) => { .run(get, set1, set2) .expectDoc({ foo: 'bar2' }); }); - }); + }).timeout(10000); it('runs transactions after getting non-existent document', async () => { return integrationHelpers.withTestDb(persistence, async db => { @@ -280,7 +280,7 @@ apiDescribe('Database transactions', (persistence: boolean) => { .run(get, set1, set2) .expectDoc({ foo: 'bar2' }); }); - }); + }).timeout(10000); it('runs transactions on existing document', async () => { return integrationHelpers.withTestDb(persistence, async db => {