From 6ecbf56aef662361adb9ecacf7c6e36ea1689f7d Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Fri, 28 Apr 2023 11:56:46 -0700 Subject: [PATCH 1/2] Catch more heartbeat read/write errors --- packages/app/src/indexeddb.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/app/src/indexeddb.ts b/packages/app/src/indexeddb.ts index 761a39bc15a..6733aa62460 100644 --- a/packages/app/src/indexeddb.ts +++ b/packages/app/src/indexeddb.ts @@ -62,10 +62,11 @@ export async function readHeartbeatsFromIndexedDB( ): Promise { try { const db = await getDbPromise(); - return db + const result = await db .transaction(STORE_NAME) .objectStore(STORE_NAME) - .get(computeKey(app)) as Promise; + .get(computeKey(app)); + return result; } catch (e) { if (e instanceof FirebaseError) { logger.warn(e.message); @@ -87,7 +88,7 @@ export async function writeHeartbeatsToIndexedDB( const tx = db.transaction(STORE_NAME, 'readwrite'); const objectStore = tx.objectStore(STORE_NAME); await objectStore.put(heartbeatObject, computeKey(app)); - return tx.done; + await tx.done; } catch (e) { if (e instanceof FirebaseError) { logger.warn(e.message); From 0822cb17569a685a2377579c7a5b17b7b989b600 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Fri, 28 Apr 2023 11:57:15 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/sixty-dolls-report.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/sixty-dolls-report.md diff --git a/.changeset/sixty-dolls-report.md b/.changeset/sixty-dolls-report.md new file mode 100644 index 00000000000..bea316d978e --- /dev/null +++ b/.changeset/sixty-dolls-report.md @@ -0,0 +1,5 @@ +--- +'@firebase/app': patch +--- + +Catch more heartbeat read/write errors.