From f0216345e84f0bf8660169e5b30c59ab57207e33 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Sun, 26 Mar 2023 14:12:48 -0700 Subject: [PATCH 1/7] Use Chrome version 110.0.5481.177-1 for Test Auth on Chrome and Node If Changed test --- .github/workflows/test-changed-auth.yml | 4 +++- packages/auth/src/api/authentication/email_link.ts | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 470c44e9aa9..f3aa7982a2c 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -16,7 +16,9 @@ jobs: - name: install Chrome stable run: | sudo apt-get update - sudo apt-get install google-chrome-stable + apt-get install wget + wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb + apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb - name: Checkout Repo uses: actions/checkout@master with: diff --git a/packages/auth/src/api/authentication/email_link.ts b/packages/auth/src/api/authentication/email_link.ts index bae82634abd..487a4af0564 100644 --- a/packages/auth/src/api/authentication/email_link.ts +++ b/packages/auth/src/api/authentication/email_link.ts @@ -30,6 +30,7 @@ export interface SignInWithEmailLinkRequest { tenantId?: string; } +// add a comment to run packages/auth tests export interface SignInWithEmailLinkResponse extends IdTokenResponse { email: string; isNewUser: boolean; From b6aa59a9dd8845b9c6ed88206da2c431399b9518 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Sun, 26 Mar 2023 16:29:13 -0700 Subject: [PATCH 2/7] add sudo --- .github/workflows/test-changed-auth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index f3aa7982a2c..63ff4f6c52f 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -16,7 +16,7 @@ jobs: - name: install Chrome stable run: | sudo apt-get update - apt-get install wget + sudo apt-get install wget wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb - name: Checkout Repo From d10c7598c531e7fcf8cdf7aa9f49348632dd1eb1 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Sun, 26 Mar 2023 16:45:50 -0700 Subject: [PATCH 3/7] add sudo to wget command --- .github/workflows/test-changed-auth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 63ff4f6c52f..9f101ebb1e6 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -17,7 +17,7 @@ jobs: run: | sudo apt-get update sudo apt-get install wget - wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb + sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb - name: Checkout Repo uses: actions/checkout@master From 895be6bd395f4d97c71cc9876b379794f3800b02 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Mon, 27 Mar 2023 10:13:30 -0700 Subject: [PATCH 4/7] add sudo to apt-get --- .github/workflows/test-changed-auth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 9f101ebb1e6..3f5781c433c 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -18,7 +18,7 @@ jobs: sudo apt-get update sudo apt-get install wget sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb - apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb + sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb - name: Checkout Repo uses: actions/checkout@master with: From 46db29b7f6ff020b8164f1f274e8d797f32331f1 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Mon, 27 Mar 2023 11:43:24 -0700 Subject: [PATCH 5/7] add --allow-downgrades --- .github/workflows/test-changed-auth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 3f5781c433c..5534f0c5ad7 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -18,7 +18,7 @@ jobs: sudo apt-get update sudo apt-get install wget sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb - sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb + sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades - name: Checkout Repo uses: actions/checkout@master with: From 8bc60893ad299cfc887101e1b322c736db822f82 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Mon, 27 Mar 2023 15:25:34 -0700 Subject: [PATCH 6/7] remove testing comment --- packages/auth/src/api/authentication/email_link.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/auth/src/api/authentication/email_link.ts b/packages/auth/src/api/authentication/email_link.ts index 487a4af0564..bae82634abd 100644 --- a/packages/auth/src/api/authentication/email_link.ts +++ b/packages/auth/src/api/authentication/email_link.ts @@ -30,7 +30,6 @@ export interface SignInWithEmailLinkRequest { tenantId?: string; } -// add a comment to run packages/auth tests export interface SignInWithEmailLinkResponse extends IdTokenResponse { email: string; isNewUser: boolean; From 26726442d44a6f5fa598d702aed3fdfdef4b87e2 Mon Sep 17 00:00:00 2001 From: Ricky Lam Date: Mon, 27 Mar 2023 17:05:59 -0700 Subject: [PATCH 7/7] add comment explaining the change --- .github/workflows/test-changed-auth.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 5534f0c5ad7..70d17c2e109 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -14,6 +14,8 @@ jobs: steps: # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo - name: install Chrome stable + # Install Chrome version 110.0.5481.177-1 as test starts to fail on version 111.0.5563.64-1. + # We will retry to use the latest, once Chrome releases stable version 112 (April 4 ETA). run: | sudo apt-get update sudo apt-get install wget