From 9c12d71e2ce92904d2c6f3b44d23748a44e19987 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 16 Mar 2023 10:48:52 -0400 Subject: [PATCH 1/2] Check typeof DOMException !== 'undefined' --- packages/firestore/src/platform/browser/base64.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/firestore/src/platform/browser/base64.ts b/packages/firestore/src/platform/browser/base64.ts index 4cbbfe6ced9..26235a36a19 100644 --- a/packages/firestore/src/platform/browser/base64.ts +++ b/packages/firestore/src/platform/browser/base64.ts @@ -22,7 +22,10 @@ export function decodeBase64(encoded: string): string { try { return atob(encoded); } catch (e) { - if (e instanceof DOMException) { + // Check that `DOMException` is defined before using it to avoid + // "ReferenceError: Property 'DOMException' doesn't exist" in react-native. + // (https://github.com/firebase/firebase-js-sdk/issues/7115) + if (typeof DOMException !== 'undefined' && e instanceof DOMException) { throw new Base64DecodeError('Invalid base64 string: ' + e); } else { throw e; From fa2146b5c79935116eeb6ebc202396f7f2690c6e Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 16 Mar 2023 10:52:26 -0400 Subject: [PATCH 2/2] yarn changeset --- .changeset/friendly-ads-yell.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/friendly-ads-yell.md diff --git a/.changeset/friendly-ads-yell.md b/.changeset/friendly-ads-yell.md new file mode 100644 index 00000000000..2da2f6dede1 --- /dev/null +++ b/.changeset/friendly-ads-yell.md @@ -0,0 +1,6 @@ +--- +'@firebase/firestore': patch +'firebase': patch +--- + +Check that DOMException exists before referencing it, to fix react-native, which was broken by https://github.com/firebase/firebase-js-sdk/pull/7019 in v9.17.2.