From 80590888bde3d519294de23054be3a255aa873bf Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 17 Nov 2022 11:03:50 -0500 Subject: [PATCH 1/3] dummy code change to trigger GitHub actions --- packages/firestore/src/core/query.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/firestore/src/core/query.ts b/packages/firestore/src/core/query.ts index 2b4fca74c3a..e1a63626db4 100644 --- a/packages/firestore/src/core/query.ts +++ b/packages/firestore/src/core/query.ts @@ -461,6 +461,7 @@ function queryMatchesPathAndCollectionGroup( doc: Document ): boolean { const docPath = doc.key.path; + debugAssert(1==1, 'dummy code change to trigger GitHub actions'); if (query.collectionGroup !== null) { // NOTE: this.path is currently always empty since we don't expose Collection // Group queries rooted at a document path yet. From 95b78f3881b55bd0362e85cfe7644215a9595120 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 17 Nov 2022 11:22:40 -0500 Subject: [PATCH 2/3] formatting fix --- packages/firestore/src/core/query.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/src/core/query.ts b/packages/firestore/src/core/query.ts index e1a63626db4..dabddd73a5f 100644 --- a/packages/firestore/src/core/query.ts +++ b/packages/firestore/src/core/query.ts @@ -461,7 +461,7 @@ function queryMatchesPathAndCollectionGroup( doc: Document ): boolean { const docPath = doc.key.path; - debugAssert(1==1, 'dummy code change to trigger GitHub actions'); + debugAssert(1 == 1, 'dummy code change to trigger GitHub actions'); if (query.collectionGroup !== null) { // NOTE: this.path is currently always empty since we don't expose Collection // Group queries rooted at a document path yet. From 7429fe0f2383bc4755a8ceb766571fcca1e7f3c1 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Thu, 17 Nov 2022 11:23:27 -0500 Subject: [PATCH 3/3] Use === instead of == --- packages/firestore/src/core/query.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/src/core/query.ts b/packages/firestore/src/core/query.ts index dabddd73a5f..ce4866cdfbf 100644 --- a/packages/firestore/src/core/query.ts +++ b/packages/firestore/src/core/query.ts @@ -461,7 +461,7 @@ function queryMatchesPathAndCollectionGroup( doc: Document ): boolean { const docPath = doc.key.path; - debugAssert(1 == 1, 'dummy code change to trigger GitHub actions'); + debugAssert(1 === 1, 'dummy code change to trigger GitHub actions'); if (query.collectionGroup !== null) { // NOTE: this.path is currently always empty since we don't expose Collection // Group queries rooted at a document path yet.