From ff0e2af0145e27221477bbc181650e3a8cee5442 Mon Sep 17 00:00:00 2001 From: Brandon Sprague Date: Fri, 7 Oct 2022 10:59:56 -0700 Subject: [PATCH 1/4] Fix modular autoinit breakage I ran into this issue updating dependencies for a Nuxt 3 app. The problem is that `process.{client,server,dev}` are defined even on the client, so the client ends up broken with errors like: ``` Uncaught TypeError: can't access property "__FIREBASE_DEFAULTS__", process.env is undefined ``` Since the code only uses `process.env`, this updates the check to look explicitly for `process.env`. --- packages/util/src/defaults.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/util/src/defaults.ts b/packages/util/src/defaults.ts index 6acc5886b5c..e9c6ec78c2e 100644 --- a/packages/util/src/defaults.ts +++ b/packages/util/src/defaults.ts @@ -57,7 +57,7 @@ const getDefaultsFromGlobal = (): FirebaseDefaults | undefined => * process.env.__FIREBASE_DEFAULTS_PATH__ */ const getDefaultsFromEnvVariable = (): FirebaseDefaults | undefined => { - if (typeof process === 'undefined') { + if (typeof process == 'undefined' || typeof process.env === 'undefined') { return; } const defaultsJsonString = process.env.__FIREBASE_DEFAULTS__; From fe9fe0fba0d031b4cbbda03019943818c18f3926 Mon Sep 17 00:00:00 2001 From: Brandon Sprague Date: Fri, 7 Oct 2022 11:08:15 -0700 Subject: [PATCH 2/4] Triple equals --- packages/util/src/defaults.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/util/src/defaults.ts b/packages/util/src/defaults.ts index e9c6ec78c2e..346e3741fd9 100644 --- a/packages/util/src/defaults.ts +++ b/packages/util/src/defaults.ts @@ -57,7 +57,7 @@ const getDefaultsFromGlobal = (): FirebaseDefaults | undefined => * process.env.__FIREBASE_DEFAULTS_PATH__ */ const getDefaultsFromEnvVariable = (): FirebaseDefaults | undefined => { - if (typeof process == 'undefined' || typeof process.env === 'undefined') { + if (typeof process === 'undefined' || typeof process.env === 'undefined') { return; } const defaultsJsonString = process.env.__FIREBASE_DEFAULTS__; From dd84bb53722fa0aa19c95bda1e5251d0bf09e4ea Mon Sep 17 00:00:00 2001 From: Brandon Sprague Date: Fri, 7 Oct 2022 12:30:27 -0700 Subject: [PATCH 3/4] Bump version to 1.7.1 for @firebase/util --- packages/util/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/util/package.json b/packages/util/package.json index 5101f6e6106..e3786e5d4b3 100644 --- a/packages/util/package.json +++ b/packages/util/package.json @@ -1,6 +1,6 @@ { "name": "@firebase/util", - "version": "1.7.0", + "version": "1.7.1", "description": "", "author": "Firebase (https://firebase.google.com/)", "main": "dist/index.node.cjs.js", @@ -61,4 +61,4 @@ ], "reportDir": "./coverage/node" } -} +} \ No newline at end of file From 57b7f5341cb3e6d836c403e6b4e941073b134756 Mon Sep 17 00:00:00 2001 From: Brandon Sprague Date: Fri, 7 Oct 2022 12:34:57 -0700 Subject: [PATCH 4/4] Fixing newlines --- packages/util/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/util/package.json b/packages/util/package.json index e3786e5d4b3..c169f7d910c 100644 --- a/packages/util/package.json +++ b/packages/util/package.json @@ -61,4 +61,4 @@ ], "reportDir": "./coverage/node" } -} \ No newline at end of file +}