From 08e4550ebbf7567a9f745e09f444258cbe9ebfbd Mon Sep 17 00:00:00 2001 From: milaGGL <107142260+milaGGL@users.noreply.github.com> Date: Wed, 31 Aug 2022 13:45:50 -0700 Subject: [PATCH 1/2] change int32 to int64 --- packages/firestore/src/protos/google/firestore/v1/query.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/src/protos/google/firestore/v1/query.proto b/packages/firestore/src/protos/google/firestore/v1/query.proto index f2d2f21fb79..dc56642f3b5 100644 --- a/packages/firestore/src/protos/google/firestore/v1/query.proto +++ b/packages/firestore/src/protos/google/firestore/v1/query.proto @@ -309,7 +309,7 @@ message StructuredAggregationQuery { // Requires: // // * Must be greater than zero when present. - int32 up_to = 1; + int64 up_to = 1; } // The type of aggregation to perform, required. From 2c667fa3b68d10b8c214a04d9a35e6aa234155cf Mon Sep 17 00:00:00 2001 From: milaGGL <107142260+milaGGL@users.noreply.github.com> Date: Thu, 1 Sep 2022 10:25:17 -0700 Subject: [PATCH 2/2] resolve comments --- packages/firestore/src/protos/google/firestore/v1/query.proto | 2 +- packages/firestore/src/protos/protos.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firestore/src/protos/google/firestore/v1/query.proto b/packages/firestore/src/protos/google/firestore/v1/query.proto index dc56642f3b5..1bb2b6cdd01 100644 --- a/packages/firestore/src/protos/google/firestore/v1/query.proto +++ b/packages/firestore/src/protos/google/firestore/v1/query.proto @@ -309,7 +309,7 @@ message StructuredAggregationQuery { // Requires: // // * Must be greater than zero when present. - int64 up_to = 1; + google.protobuf.Int64Value up_to = 1; } // The type of aggregation to perform, required. diff --git a/packages/firestore/src/protos/protos.json b/packages/firestore/src/protos/protos.json index b6401193bab..093e22c6451 100644 --- a/packages/firestore/src/protos/protos.json +++ b/packages/firestore/src/protos/protos.json @@ -2427,7 +2427,7 @@ "Count": { "fields": { "upTo": { - "type": "int32", + "type": "google.protobuf.Int64Value", "id": 1 } }