From 58ddf45a1158e10f8429770790ad3f1c58340c23 Mon Sep 17 00:00:00 2001 From: jbalidiong Date: Fri, 17 Jun 2022 01:24:03 +0800 Subject: [PATCH 1/2] update the assertSucceed reference doc to the public doc --- packages/rules-unit-testing/src/util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rules-unit-testing/src/util.ts b/packages/rules-unit-testing/src/util.ts index e6f7cc87b9c..1cb823c39d5 100644 --- a/packages/rules-unit-testing/src/util.ts +++ b/packages/rules-unit-testing/src/util.ts @@ -162,7 +162,7 @@ export function assertFails(pr: Promise): Promise { } /** - * Assert the promise to be rejected with a "permission denied" error. + * Assert the promise to be successful with no Security Rules error. * * This is a no-op function returning the passed promise as-is, but can be used for documentational * purposes in test code to emphasize that a certain request should succeed (e.g. allowed by rules). From 1895d5de7e05897e8e735d05f4a7e4774ae5d5c3 Mon Sep 17 00:00:00 2001 From: jbalidiong Date: Fri, 24 Jun 2022 01:40:26 +0800 Subject: [PATCH 2/2] adjusted changes based from the comment --- packages/rules-unit-testing/src/util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rules-unit-testing/src/util.ts b/packages/rules-unit-testing/src/util.ts index 1cb823c39d5..9ec9d129b4d 100644 --- a/packages/rules-unit-testing/src/util.ts +++ b/packages/rules-unit-testing/src/util.ts @@ -162,7 +162,7 @@ export function assertFails(pr: Promise): Promise { } /** - * Assert the promise to be successful with no Security Rules error. + * Assert the promise to be successful. * * This is a no-op function returning the passed promise as-is, but can be used for documentational * purposes in test code to emphasize that a certain request should succeed (e.g. allowed by rules).