Fix the cursor expanding result set bug #6166

wu-hui · 2022-04-19T14:15:07Z

No description provided.

changeset-bot · 2022-04-19T14:15:10Z

⚠️ No Changeset found

Latest commit: 8e353c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-04-19T15:44:23Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (9417675) Merge (9d73ac2) Diff
browser 253 kB 253 kB +251 B (+0.1%)
esm5 314 kB 314 kB +217 B (+0.1%)
main 505 kB 505 kB +158 B (+0.0%)
module 253 kB 253 kB +251 B (+0.1%)
react-native 253 kB 253 kB +251 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
browser	73.1 kB	73.3 kB	+131 B (+0.2%)
esm5	86.5 kB	86.7 kB	+129 B (+0.1%)
main	126 kB	126 kB	+245 B (+0.2%)
module	73.1 kB	73.3 kB	+131 B (+0.2%)
react-native	73.3 kB	73.5 kB	+131 B (+0.2%)

@firebase/functions
Type Base (9417675) Merge (9d73ac2) Diff
browser 8.99 kB 9.39 kB +397 B (+4.4%)
esm5 11.1 kB 11.5 kB +414 B (+3.7%)
main 11.8 kB 12.4 kB +529 B (+4.5%)
module 8.99 kB 9.39 kB +397 B (+4.4%)
@firebase/functions-compat
Type Base (9417675) Merge (9d73ac2) Diff
browser 1.68 kB 1.79 kB +111 B (+6.6%)
esm5 1.83 kB 1.98 kB +148 B (+8.1%)
main 2.20 kB 2.34 kB +137 B (+6.2%)
module 1.68 kB 1.79 kB +111 B (+6.6%)

`bundle`

13 size changes

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
firestore (Persistence)	263 kB	263 kB	+251 B (+0.1%)
firestore (Query Cursors)	203 kB	203 kB	+178 B (+0.1%)
firestore (Query)	204 kB	204 kB	+178 B (+0.1%)
firestore (Read data once)	192 kB	192 kB	+178 B (+0.1%)
firestore (Realtime updates)	194 kB	195 kB	+178 B (+0.1%)
firestore (Transaction)	177 kB	177 kB	+178 B (+0.1%)
firestore (Write data)	176 kB	176 kB	+178 B (+0.1%)
firestore-lite (Query Cursors)	66.3 kB	66.3 kB	+13 B (+0.0%)
firestore-lite (Query)	69.4 kB	69.5 kB	+131 B (+0.2%)
firestore-lite (Read data once)	53.9 kB	53.9 kB	+15 B (+0.0%)
firestore-lite (Transaction)	71.2 kB	71.2 kB	+15 B (+0.0%)
firestore-lite (Write data)	56.6 kB	56.6 kB	+15 B (+0.0%)
functions (call)	27.6 kB	27.6 kB	+40 B (+0.1%)

`firebase`

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
firebase-compat.js	779 kB	780 kB	+424 B (+0.1%)
firebase-firestore-compat.js	304 kB	305 kB	+245 B (+0.1%)
firebase-firestore-lite.js	250 kB	250 kB	+234 B (+0.1%)
firebase-firestore.js	824 kB	824 kB	+291 B (+0.0%)
firebase-functions-compat.js	7.95 kB	8.12 kB	+169 B (+2.1%)
firebase-functions.js	31.1 kB	32.0 kB	+947 B (+3.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/GAwGUUZcJa.html

google-oss-bot · 2022-04-19T16:09:36Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 23.9 kB 23.9 kB +15 B (+0.1%)
  size-with-ext-deps 81.7 kB 81.7 kB +15 B (+0.0%)
- Transaction
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 42.4 kB 42.4 kB +15 B (+0.0%)
  size-with-ext-deps 100 kB 100 kB +15 B (+0.0%)
- WriteBatch
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 39.2 kB 39.3 kB +15 B (+0.0%)
  size-with-ext-deps 97.1 kB 97.2 kB +15 B (+0.0%)
- addDoc
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 110 kB 110 kB +178 B (+0.2%)
  size-with-ext-deps 169 kB 169 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mh mi wt x zc
  19 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mh mi wt x zc
  + Nt
- deleteDoc
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 101 kB 101 kB +178 B (+0.2%)
  size-with-ext-deps 160 kB 160 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  16 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mi wt x
  17 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mi wt x
  + Nt
- disableNetwork
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 89.4 kB 89.6 kB +178 B (+0.2%)
  size-with-ext-deps 148 kB 149 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Uo Xn ic jn wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn ic jn wt x
  + Nt
- enableIndexedDbPersistence
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 165 kB 166 kB +251 B (+0.2%)
  size-with-ext-deps 225 kB 225 kB +251 B (+0.1%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 197 kB 197 kB +251 B (+0.1%)
  size-with-ext-deps 257 kB 257 kB +251 B (+0.1%)
- enableNetwork
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 89.4 kB 89.6 kB +178 B (+0.2%)
  size-with-ext-deps 148 kB 149 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Uo Xn ic jn wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn ic jn wt x
  + Nt
- executeWrite
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 99.9 kB 100 kB +178 B (+0.2%)
  size-with-ext-deps 159 kB 159 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  16 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mi wt x
  17 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mi wt x
  + Nt
- getDoc
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 126 kB 126 kB +178 B (+0.1%)
  size-with-ext-deps 185 kB 185 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mh mi wt x
  19 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mh mi wt x
  + Nt
- getDocFromCache
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 82.5 kB 82.7 kB +178 B (+0.2%)
  size-with-ext-deps 140 kB 141 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Xn ic jn mh wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Xn ic jn mh wt x
  + Nt
- getDocFromServer
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 126 kB 126 kB +178 B (+0.1%)
  size-with-ext-deps 185 kB 185 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mh mi wt x
  19 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mh mi wt x
  + Nt
- getDocs
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 128 kB 128 kB +178 B (+0.1%)
  size-with-ext-deps 187 kB 187 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mh mi wt x
  19 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mh mi wt x
  + Nt
- getDocsFromCache
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 90.0 kB 90.2 kB +178 B (+0.2%)
  size-with-ext-deps 148 kB 148 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Xn ic jn mh wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Xn ic jn mh wt x
  + Nt
- getDocsFromServer
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 127 kB 128 kB +178 B (+0.1%)
  size-with-ext-deps 186 kB 187 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mh mi wt x
  19 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mh mi wt x
  + Nt
- loadBundle
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 98.3 kB 98.5 kB +178 B (+0.2%)
  size-with-ext-deps 157 kB 158 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Uo Xn ic jn wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn ic jn wt x
  + Nt
- namedQuery
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 76.0 kB 76.2 kB +178 B (+0.2%)
  size-with-ext-deps 134 kB 134 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  13 dependencies
  Bn D G Gn It Jn Ln N Xn ic jn wt x
  14 dependencies
  Bn D G Gn It Jn Ln N Nt Xn ic jn wt x
  + Nt
- onSnapshot
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 128 kB 128 kB +178 B (+0.1%)
  size-with-ext-deps 187 kB 187 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mh mi wt x
  19 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mh mi wt x
  + Nt
- onSnapshotsInSync
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 118 kB 118 kB +178 B (+0.2%)
  size-with-ext-deps 177 kB 177 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  17 dependencies
  Bn D G Gn It Jn Ln N Uo Xn cs hs ic jn mi wt x
  18 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn cs hs ic jn mi wt x
  + Nt
- queryEqual
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 25.9 kB 25.9 kB +13 B (+0.1%)
  size-with-ext-deps 83.7 kB 83.8 kB +13 B (+0.0%)
- runTransaction
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 110 kB 110 kB +178 B (+0.2%)
  size-with-ext-deps 169 kB 169 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  16 dependencies
  Bn D G Gn It Jn Ln N Uo Xn ic jn mh wt x zc
  17 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn ic jn mh wt x zc
  + Nt
- setDoc
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 109 kB 109 kB +178 B (+0.2%)
  size-with-ext-deps 168 kB 168 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mh mi wt x zc
  19 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mh mi wt x zc
  + Nt
- snapshotEqual
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 32.7 kB 32.7 kB +13 B (+0.0%)
  size-with-ext-deps 90.5 kB 90.6 kB +13 B (+0.0%)
- updateDoc
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 109 kB 110 kB +178 B (+0.2%)
  size-with-ext-deps 168 kB 169 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mh mi wt x zc
  19 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mh mi wt x zc
  + Nt
- waitForPendingWrites
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 89.8 kB 90.0 kB +178 B (+0.2%)
  size-with-ext-deps 149 kB 149 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  14 dependencies
  Bn D G Gn It Jn Ln N Uo Xn ic jn wt x
  15 dependencies
  Bn D G Gn It Jn Ln N Nt Uo Xn ic jn wt x
  + Nt
- where
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 40.7 kB 40.9 kB +181 B (+0.4%)
  size-with-ext-deps 98.6 kB 98.8 kB +180 B (+0.2%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  11 dependencies
  Bn D G It Ln N ic mh wt x zc
  12 dependencies
  Bn D G It Ln N Nt ic mh wt x zc
  + Nt
- writeBatch
  Size
  Type Base (9417675) Merge (9d73ac2) Diff
  size 111 kB 112 kB +178 B (+0.2%)
  size-with-ext-deps 170 kB 171 kB +178 B (+0.1%)
  Dependency
  Type Base (9417675) Merge (9d73ac2) Diff
  variables
  18 dependencies
  Bn D G Gn Hn It Jn Ln N Uo Xn ic jn mh mi wt x zc
  19 dependencies
  Bn D G Gn Hn It Jn Ln N Nt Uo Xn ic jn mh mi wt x zc
  + Nt

`@firebase/functions`

`httpsCallable`

Size

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
size	5.98 kB	6.02 kB	+38 B (+0.6%)
size-with-ext-deps	21.1 kB	21.1 kB	+40 B (+0.2%)

Dependency

Type Base (9417675) Merge (9d73ac2) Diff

functions

11 dependencies

_errorForResponse
call
codeForHTTPStatus
decode
encode
failAfter
httpsCallable
httpsCallable$1
mapValues
postJSON
registerFunctions

12 dependencies

_errorForResponse
call
callAtURL
codeForHTTPStatus
decode
encode
failAfter
httpsCallable
httpsCallable$1
mapValues
postJSON
registerFunctions

+ callAtURL

`httpsCallableFromURL`

Size

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
size	?	5.97 kB	? (?)
size-with-ext-deps	?	21.1 kB	? (?)

Dependency

Type	Base (`9417675`)	Merge (`9d73ac2`)	Diff
functions	?	11 dependencies _errorForResponse callAtURL codeForHTTPStatus decode encode failAfter httpsCallableFromURL httpsCallableFromURL$1 mapValues postJSON registerFunctions	?
classes	?	ContextProvider FunctionsError FunctionsService	?
variables	?	APP_CHECK_INTERNAL_NAME AUTH_INTERNAL_NAME DEFAULT_REGION FUNCTIONS_TYPE LONG_TYPE MESSAGING_INTERNAL_NAME UNSIGNED_LONG_TYPE errorCodeMap name version	?
enums	?		?

External Dependency

Module	Base (`9417675`)	Merge (`9d73ac2`)	Diff
`@firebase/app`	?	_registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/util`	?	FirebaseError getModularInstance	?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/yVr86mrOTN.html

# Conflicts: # packages/firestore/src/local/indexeddb_index_manager.ts

ehsannas · 2022-04-21T03:54:04Z

packages/firestore/src/model/values.ts

@@ -78,7 +78,7 @@ export function typeOrder(value: Value): TypeOrder {
    if (isServerTimestamp(value)) {
      return TypeOrder.ServerTimestampValue;
    } else if (isMaxValue(value)) {
-      return TypeOrder.ArrayValue;
+      return TypeOrder.ObjectValue;


should this be TypeOrder.MaxValue? Android reference

ehsannas · 2022-04-21T04:08:59Z

packages/firestore/test/unit/local/index_manager.test.ts

+    );
+    await verifyResults(testingQuery, 'coll/val1');
+  });
+


can you also add another test (or just add to the existing test) for the other direction? e.g. c < 2 order by c DESC with bound 2 inclusive.

And that uncovers one more bug.

Temp commit

992b87a

Proper fix.

923ad28

wu-hui requested a review from ehsannas April 19, 2022 15:24

wu-hui assigned ehsannas Apr 19, 2022

wu-hui added 4 commits April 19, 2022 12:13

More refactoring.

684a49f

Even more.

4b8ce9a

Merge branch 'master' into wuandy/FixCursorExpand

e92bae1

# Conflicts: # packages/firestore/src/local/indexeddb_index_manager.ts

Fix merge error.

e8c8985

ehsannas reviewed Apr 21, 2022

View reviewed changes

More fix and more test

8e353c6

ehsannas approved these changes Apr 21, 2022

View reviewed changes

wu-hui merged commit dc0e926 into master Apr 21, 2022

wu-hui deleted the wuandy/FixCursorExpand branch April 21, 2022 18:54

firebase locked and limited conversation to collaborators May 22, 2022

Fix the cursor expanding result set bug #6166

Fix the cursor expanding result set bug #6166

Conversation

wu-hui commented Apr 19, 2022

changeset-bot bot commented Apr 19, 2022 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Apr 19, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/functions-compat

bundle

firebase

Test Logs

google-oss-bot commented Apr 19, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

Transaction

WriteBatch

addDoc

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

loadBundle

namedQuery

onSnapshot

onSnapshotsInSync

queryEqual

runTransaction

setDoc

snapshotEqual

updateDoc

waitForPendingWrites

where

writeBatch

@firebase/functions

httpsCallable

httpsCallableFromURL

Test Logs

ehsannas Apr 21, 2022

Choose a reason for hiding this comment

wu-hui Apr 21, 2022

Choose a reason for hiding this comment

ehsannas Apr 21, 2022

Choose a reason for hiding this comment

wu-hui Apr 21, 2022

Choose a reason for hiding this comment

changeset-bot bot commented Apr 19, 2022 •

edited

Loading

google-oss-bot commented Apr 19, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/functions-compat`

`bundle`

`firebase`

google-oss-bot commented Apr 19, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`Transaction`

`WriteBatch`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`loadBundle`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`queryEqual`

`runTransaction`

`setDoc`

`snapshotEqual`

`updateDoc`

`waitForPendingWrites`

`where`

`writeBatch`

`@firebase/functions`

`httpsCallable`

`httpsCallableFromURL`