From 80d84999ef6770f84d9a00fc8d73f1aa355d2b33 Mon Sep 17 00:00:00 2001 From: Sam Olsen Date: Thu, 4 Nov 2021 13:50:36 -0700 Subject: [PATCH 1/2] Add tabindex=-1 to iframe to fix issue with aria-hidden --- packages/auth/src/platform_browser/iframe/iframe.test.ts | 1 + packages/auth/src/platform_browser/iframe/iframe.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/auth/src/platform_browser/iframe/iframe.test.ts b/packages/auth/src/platform_browser/iframe/iframe.test.ts index f1bf2cc54ed..daa0864cfa9 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.test.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.test.ts @@ -86,6 +86,7 @@ describe('platform_browser/iframe/iframe', () => { height: '1px' }, 'aria-hidden': 'true', + tabindex: '-1' }); expect(iframeSettings.dontclear).to.be.true; }); diff --git a/packages/auth/src/platform_browser/iframe/iframe.ts b/packages/auth/src/platform_browser/iframe/iframe.ts index 86d4c5b228d..e1ccd6273f1 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.ts @@ -38,7 +38,8 @@ const IFRAME_ATTRIBUTES = { width: '1px', height: '1px' }, - 'aria-hidden': 'true' + 'aria-hidden': 'true', + tabindex: '-1' }; // Map from apiHost to endpoint ID for passing into iframe. In current SDK, apiHost can be set to From b8f3172628a4c8a40f917679c7acf23ca427ea68 Mon Sep 17 00:00:00 2001 From: Sam Date: Thu, 4 Nov 2021 13:53:03 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/witty-kids-buy.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/witty-kids-buy.md diff --git a/.changeset/witty-kids-buy.md b/.changeset/witty-kids-buy.md new file mode 100644 index 00000000000..fdf5fefc956 --- /dev/null +++ b/.changeset/witty-kids-buy.md @@ -0,0 +1,5 @@ +--- +"@firebase/auth": patch +--- + +Fix lighthouse issues related to the embedded iframe used to perform OAuth sign in.