diff --git a/.changeset/witty-kids-buy.md b/.changeset/witty-kids-buy.md new file mode 100644 index 00000000000..fdf5fefc956 --- /dev/null +++ b/.changeset/witty-kids-buy.md @@ -0,0 +1,5 @@ +--- +"@firebase/auth": patch +--- + +Fix lighthouse issues related to the embedded iframe used to perform OAuth sign in. diff --git a/packages/auth/src/platform_browser/iframe/iframe.test.ts b/packages/auth/src/platform_browser/iframe/iframe.test.ts index f1bf2cc54ed..daa0864cfa9 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.test.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.test.ts @@ -86,6 +86,7 @@ describe('platform_browser/iframe/iframe', () => { height: '1px' }, 'aria-hidden': 'true', + tabindex: '-1' }); expect(iframeSettings.dontclear).to.be.true; }); diff --git a/packages/auth/src/platform_browser/iframe/iframe.ts b/packages/auth/src/platform_browser/iframe/iframe.ts index 86d4c5b228d..e1ccd6273f1 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.ts @@ -38,7 +38,8 @@ const IFRAME_ATTRIBUTES = { width: '1px', height: '1px' }, - 'aria-hidden': 'true' + 'aria-hidden': 'true', + tabindex: '-1' }; // Map from apiHost to endpoint ID for passing into iframe. In current SDK, apiHost can be set to