From fe283d5cc03c4d1e9cd4a31ce151e5118d5587ec Mon Sep 17 00:00:00 2001 From: Sam Olsen Date: Mon, 18 Oct 2021 11:48:57 -0700 Subject: [PATCH 1/2] Add aria-hidden='true' attribute to embedded iframe --- packages/auth/src/platform_browser/iframe/iframe.test.ts | 3 ++- packages/auth/src/platform_browser/iframe/iframe.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/auth/src/platform_browser/iframe/iframe.test.ts b/packages/auth/src/platform_browser/iframe/iframe.test.ts index e5198e206ca..de0207ab3e8 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.test.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.test.ts @@ -84,7 +84,8 @@ describe('platform_browser/iframe/iframe', () => { top: '-100px', width: '1px', height: '1px' - } + }, + 'aria-hidden': 'true', }); expect(iframeSettings.dontclear).to.be.true; }); diff --git a/packages/auth/src/platform_browser/iframe/iframe.ts b/packages/auth/src/platform_browser/iframe/iframe.ts index e32615c7ece..86d4c5b228d 100644 --- a/packages/auth/src/platform_browser/iframe/iframe.ts +++ b/packages/auth/src/platform_browser/iframe/iframe.ts @@ -37,7 +37,8 @@ const IFRAME_ATTRIBUTES = { top: '-100px', width: '1px', height: '1px' - } + }, + 'aria-hidden': 'true' }; // Map from apiHost to endpoint ID for passing into iframe. In current SDK, apiHost can be set to From f53a226f2e75b5131e2e1f416613eef93bb4bc95 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 18 Oct 2021 12:11:56 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/olive-coats-deliver.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/olive-coats-deliver.md diff --git a/.changeset/olive-coats-deliver.md b/.changeset/olive-coats-deliver.md new file mode 100644 index 00000000000..83501e5684b --- /dev/null +++ b/.changeset/olive-coats-deliver.md @@ -0,0 +1,5 @@ +--- +"@firebase/auth": patch +--- + +Add the attribute `aria-hidden="true"` to the embedded iframe