From f574db3faa53f9c5c91368cff122bb56ebd43e6e Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Thu, 29 Jul 2021 14:56:48 -0700 Subject: [PATCH 1/2] Add storage to Node bundle and Node docs --- packages-exp/firebase-exp/compat/index.d.ts | 3 --- packages-exp/firebase-exp/compat/index.node.ts | 1 + packages/firebase/index.d.ts | 3 --- packages/firebase/src/index.node.ts | 1 + 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages-exp/firebase-exp/compat/index.d.ts b/packages-exp/firebase-exp/compat/index.d.ts index 6b0a3489df7..43a9b4e3f28 100644 --- a/packages-exp/firebase-exp/compat/index.d.ts +++ b/packages-exp/firebase-exp/compat/index.d.ts @@ -7451,9 +7451,6 @@ declare namespace firebase.messaging { function isSupported(): boolean; } -/** - * @webonly - */ declare namespace firebase.storage { /** * The full set of object metadata, including read-only properties. diff --git a/packages-exp/firebase-exp/compat/index.node.ts b/packages-exp/firebase-exp/compat/index.node.ts index a7442d90f28..d79f99186fc 100644 --- a/packages-exp/firebase-exp/compat/index.node.ts +++ b/packages-exp/firebase-exp/compat/index.node.ts @@ -22,6 +22,7 @@ import './auth'; import './database'; import './firestore'; import './functions'; +import './storage'; firebase.registerVersion(name, version, 'compat-node'); diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts index d870b4b5eec..3d0f699bae7 100644 --- a/packages/firebase/index.d.ts +++ b/packages/firebase/index.d.ts @@ -7499,9 +7499,6 @@ declare namespace firebase.messaging { function isSupported(): boolean; } -/** - * @webonly - */ declare namespace firebase.storage { /** * The full set of object metadata, including read-only properties. diff --git a/packages/firebase/src/index.node.ts b/packages/firebase/src/index.node.ts index 2631cefd258..2e152f553d3 100644 --- a/packages/firebase/src/index.node.ts +++ b/packages/firebase/src/index.node.ts @@ -23,6 +23,7 @@ import '../database'; import '../firestore'; import '../firestore/bundle'; import '../functions'; +import '../storage'; firebase.registerVersion(name, version, 'node'); From 1991ffba9e05569245242b94df72ffd3dc932bad Mon Sep 17 00:00:00 2001 From: hsubox76 Date: Thu, 29 Jul 2021 23:05:47 +0000 Subject: [PATCH 2/2] Update API reports --- common/api-review/analytics-exp.api.md | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/common/api-review/analytics-exp.api.md b/common/api-review/analytics-exp.api.md index c61755d6491..b7f381967a0 100644 --- a/common/api-review/analytics-exp.api.md +++ b/common/api-review/analytics-exp.api.md @@ -59,8 +59,6 @@ export interface EventParams { // (undocumented) checkout_step?: number; // (undocumented) - content_id?: string; - // (undocumented) content_type?: string; // (undocumented) coupon?: string; @@ -77,6 +75,8 @@ export interface EventParams { firebase_screen?: string; firebase_screen_class?: string; // (undocumented) + item_id?: string; + // (undocumented) item_list_id?: string; // (undocumented) item_list_name?: string; @@ -125,18 +125,12 @@ export interface GtagConfigParams { // (undocumented) [key: string]: unknown; 'allow_ad_personalization_signals'?: boolean; - 'anonymize_ip'?: boolean; 'cookie_domain'?: string; 'cookie_expires'?: number; 'cookie_flags'?: string; 'cookie_prefix'?: string; 'cookie_update'?: boolean; - 'custom_map'?: { - [key: string]: unknown; - }; - 'link_attribution'?: boolean; 'page_location'?: string; - 'page_path'?: string; 'page_title'?: string; 'send_page_view'?: boolean; } @@ -262,7 +256,6 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'exception', e export function logEvent(analyticsInstance: Analytics, eventName: 'generate_lead', eventParams?: { value?: EventParams['value']; currency?: EventParams['currency']; - transaction_id?: EventParams['transaction_id']; [key: string]: any; }, options?: AnalyticsCallOptions): void; @@ -295,13 +288,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | ' // @public export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams?: { - app_name: string; - screen_name: EventParams['screen_name']; firebase_screen: EventParams['firebase_screen']; firebase_screen_class: EventParams['firebase_screen_class']; - app_id?: string; - app_version?: string; - app_installer_id?: string; [key: string]: any; }, options?: AnalyticsCallOptions): void; @@ -313,10 +301,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'search' | 'vi // @public export function logEvent(analyticsInstance: Analytics, eventName: 'select_content', eventParams?: { - items?: EventParams['items']; - promotions?: EventParams['promotions']; content_type?: EventParams['content_type']; - content_id?: EventParams['content_id']; + item_id?: EventParams['item_id']; [key: string]: any; }, options?: AnalyticsCallOptions): void; @@ -347,7 +333,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'set_checkout_ export function logEvent(analyticsInstance: Analytics, eventName: 'share', eventParams?: { method?: EventParams['method']; content_type?: EventParams['content_type']; - content_id?: EventParams['content_id']; + item_id?: EventParams['item_id']; [key: string]: any; }, options?: AnalyticsCallOptions): void;