From 31c8b23cf6f3163f828d1e65759e6535b7f221e6 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Thu, 29 Oct 2020 08:37:48 -0700 Subject: [PATCH 1/8] add a letter --- .github/workflows/check-changeset.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-changeset.yml b/.github/workflows/check-changeset.yml index d8082f09804..d5a52c09013 100644 --- a/.github/workflows/check-changeset.yml +++ b/.github/workflows/check-changeset.yml @@ -22,7 +22,7 @@ jobs: - name: Run changeset script run: yarn ts-node-script scripts/check_changeset.ts id: check-changeset - - name: Print changeset checker output + - name: Print changeset checker outputx run: echo "${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}" - name: Find Comment uses: peter-evans/find-comment@v1 From 350956fc1028a1209acfc9bb98b7ff1771710aa8 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Thu, 29 Oct 2020 08:47:41 -0700 Subject: [PATCH 2/8] add changeset --- .changeset/giant-pants-relax.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/giant-pants-relax.md diff --git a/.changeset/giant-pants-relax.md b/.changeset/giant-pants-relax.md new file mode 100644 index 00000000000..b41135a7bc6 --- /dev/null +++ b/.changeset/giant-pants-relax.md @@ -0,0 +1,5 @@ +--- +'@firebase/app-compat': patch +--- + +test From 12456aba52aaa6a6ee1ddfea901ac5427e4bba07 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Thu, 29 Oct 2020 09:39:04 -0700 Subject: [PATCH 3/8] Does this work --- scripts/check_changeset.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/check_changeset.ts b/scripts/check_changeset.ts index 41532423f03..aa1a4e25de8 100644 --- a/scripts/check_changeset.ts +++ b/scripts/check_changeset.ts @@ -87,6 +87,7 @@ async function main() { const errors = []; try { await exec('yarn changeset status'); + console.log(`::set-output name=BLOCKING_FAILURE::false`); } catch (e) { const messageLines = e.message.replace(/🦋 error /g, '').split('\n'); let formattedStatusError = From 12c8a5a1f3e725ab6c31083923972df33c2ef2d7 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Mon, 2 Nov 2020 15:13:00 -0800 Subject: [PATCH 4/8] Add debugging echo statement --- .github/workflows/check-changeset.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-changeset.yml b/.github/workflows/check-changeset.yml index d5a52c09013..fba28d701e2 100644 --- a/.github/workflows/check-changeset.yml +++ b/.github/workflows/check-changeset.yml @@ -22,8 +22,10 @@ jobs: - name: Run changeset script run: yarn ts-node-script scripts/check_changeset.ts id: check-changeset - - name: Print changeset checker outputx + - name: Print changeset checker output run: echo "${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}" + - name: Print blocking failure status + run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}" - name: Find Comment uses: peter-evans/find-comment@v1 id: fc From 9ca42657145e65dcabd2e08bd38c3c444781fcdc Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Mon, 2 Nov 2020 15:37:18 -0800 Subject: [PATCH 5/8] Check for BLOCKING_FAILURE string value --- .github/workflows/check-changeset.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-changeset.yml b/.github/workflows/check-changeset.yml index fba28d701e2..8eb8be911c8 100644 --- a/.github/workflows/check-changeset.yml +++ b/.github/workflows/check-changeset.yml @@ -61,5 +61,5 @@ jobs: - No changeset formatting errors detected. # Don't want it to throw before editing the comment. - name: Fail if checker script logged a blocking failure - if: ${{steps.check-changeset.outputs.BLOCKING_FAILURE}} + if: ${{steps.check-changeset.outputs.BLOCKING_FAILURE == 'true'}} run: exit 1 \ No newline at end of file From bf7771379acc034b6dfdc2b3075b4a35e497a8ee Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Mon, 2 Nov 2020 15:44:02 -0800 Subject: [PATCH 6/8] Make a blocking failure --- .changeset/giant-pants-relax.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/giant-pants-relax.md b/.changeset/giant-pants-relax.md index b41135a7bc6..e80eebf5aee 100644 --- a/.changeset/giant-pants-relax.md +++ b/.changeset/giant-pants-relax.md @@ -1,5 +1,5 @@ --- -'@firebase/app-compat': patch +'@firebase/app-compat: patch --- test From 26ac5f89b8749e99841cced433b89fd018f5596f Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Mon, 2 Nov 2020 16:11:22 -0800 Subject: [PATCH 7/8] Correct blocking failure --- .changeset/giant-pants-relax.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/giant-pants-relax.md b/.changeset/giant-pants-relax.md index e80eebf5aee..b41135a7bc6 100644 --- a/.changeset/giant-pants-relax.md +++ b/.changeset/giant-pants-relax.md @@ -1,5 +1,5 @@ --- -'@firebase/app-compat: patch +'@firebase/app-compat': patch --- test From c6ff26e866b8fa235c3c79cb642fb4eaee3c6623 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Mon, 2 Nov 2020 17:04:44 -0800 Subject: [PATCH 8/8] Remove test changeset file --- .changeset/giant-pants-relax.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/giant-pants-relax.md diff --git a/.changeset/giant-pants-relax.md b/.changeset/giant-pants-relax.md deleted file mode 100644 index b41135a7bc6..00000000000 --- a/.changeset/giant-pants-relax.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@firebase/app-compat': patch ---- - -test