From 2056681f0deb7b837640f469f62038bda6038cf9 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Mon, 21 Sep 2020 11:08:36 -0700 Subject: [PATCH 1/2] Addess negative zero ESLint validation --- packages/firestore/src/util/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/src/util/types.ts b/packages/firestore/src/util/types.ts index 1e83e0bbe53..a2d437d3c3a 100644 --- a/packages/firestore/src/util/types.ts +++ b/packages/firestore/src/util/types.ts @@ -31,7 +31,7 @@ export function isNullOrUndefined(value: unknown): value is null | undefined { export function isNegativeZero(value: number): boolean { // Detect if the value is -0.0. Based on polyfill from // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is - return value === -0 && 1 / value === 1 / -0; + return value === 0 && 1 / value === 1 / -0; } /** From c1c3ae3a1f18ff80747b2310051bfaa7c148a644 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Mon, 21 Sep 2020 11:15:03 -0700 Subject: [PATCH 2/2] Create moody-jobs-deliver.md --- .changeset/moody-jobs-deliver.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/moody-jobs-deliver.md diff --git a/.changeset/moody-jobs-deliver.md b/.changeset/moody-jobs-deliver.md new file mode 100644 index 00000000000..b4c6464e6c3 --- /dev/null +++ b/.changeset/moody-jobs-deliver.md @@ -0,0 +1,5 @@ +--- +"@firebase/firestore": patch +--- + +Fixes a "Comparison with -0" lint warning for customers that build from source.