From 1048994c1786fda508d3079231764daa4aa56e51 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 9 Sep 2020 10:48:47 -0700 Subject: [PATCH 1/3] Temporarily exclude flaky test. --- repo-scripts/size-analysis/test/size-analysis.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/repo-scripts/size-analysis/test/size-analysis.test.ts b/repo-scripts/size-analysis/test/size-analysis.test.ts index 1e1eb768a5b..0c4cdff366f 100644 --- a/repo-scripts/size-analysis/test/size-analysis.test.ts +++ b/repo-scripts/size-analysis/test/size-analysis.test.ts @@ -196,7 +196,9 @@ describe('extractDeclarations on .d.ts file', () => { expect(extractedDeclarations.variables).to.include.members(['aVar']); }); }); -describe('extractDeclarations on js bundle file', () => { +//TODO: Temporarily disabled due to causing timeout issues. +// eslint-disable-next-line no-restricted-globals +xdescribe('extractDeclarations on js bundle file', () => { let subsetExportsBundleFile: string; let extractedDeclarations: MemberList; before(() => { From c1b893dfbd5a458c31ec7d12f88dae668a59ee51 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 9 Sep 2020 11:32:04 -0700 Subject: [PATCH 2/3] Test if extending timeout works --- repo-scripts/size-analysis/test/size-analysis.test.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/repo-scripts/size-analysis/test/size-analysis.test.ts b/repo-scripts/size-analysis/test/size-analysis.test.ts index 0c4cdff366f..3163a21b9fe 100644 --- a/repo-scripts/size-analysis/test/size-analysis.test.ts +++ b/repo-scripts/size-analysis/test/size-analysis.test.ts @@ -196,9 +196,7 @@ describe('extractDeclarations on .d.ts file', () => { expect(extractedDeclarations.variables).to.include.members(['aVar']); }); }); -//TODO: Temporarily disabled due to causing timeout issues. -// eslint-disable-next-line no-restricted-globals -xdescribe('extractDeclarations on js bundle file', () => { +describe('extractDeclarations on js bundle file', () => { let subsetExportsBundleFile: string; let extractedDeclarations: MemberList; before(() => { @@ -250,7 +248,7 @@ xdescribe('extractDeclarations on js bundle file', () => { classesArray.sort(); expect(extractedDeclarations.classes).to.have.members(classesArray); }); -}); +}).timeout(120000); describe('test dedup helper function', () => { it('test dedup with non-empty entries', () => { From 9dc49db8acea802a5a34d1210daa397a418107c5 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 9 Sep 2020 12:11:12 -0700 Subject: [PATCH 3/3] Move timeout to before specifically --- repo-scripts/size-analysis/test/size-analysis.test.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/repo-scripts/size-analysis/test/size-analysis.test.ts b/repo-scripts/size-analysis/test/size-analysis.test.ts index 3163a21b9fe..55326752cbf 100644 --- a/repo-scripts/size-analysis/test/size-analysis.test.ts +++ b/repo-scripts/size-analysis/test/size-analysis.test.ts @@ -199,7 +199,8 @@ describe('extractDeclarations on .d.ts file', () => { describe('extractDeclarations on js bundle file', () => { let subsetExportsBundleFile: string; let extractedDeclarations: MemberList; - before(() => { + before(function () { + this.timeout(120000); const start = Date.now(); const testModuleDtsFile: string = getTestModuleDtsFilePath(); const map: Map = buildMap( @@ -248,7 +249,7 @@ describe('extractDeclarations on js bundle file', () => { classesArray.sort(); expect(extractedDeclarations.classes).to.have.members(classesArray); }); -}).timeout(120000); +}); describe('test dedup helper function', () => { it('test dedup with non-empty entries', () => {