From 40bd2421bed3c0346b3a06da9b4e295bbc6c7f41 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 09:47:45 -0700 Subject: [PATCH 1/7] test --- scripts/exp/release.ts | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/scripts/exp/release.ts b/scripts/exp/release.ts index 2ee79be86f1..ba1372b285f 100644 --- a/scripts/exp/release.ts +++ b/scripts/exp/release.ts @@ -69,27 +69,27 @@ async function publishExpPackages() { /** * Release packages to NPM - */ - await publishToNpm(packagePaths); - - /** - * reset the working tree to recover package names with -exp in the package.json files, - * then bump patch version of firebase-exp (the umbrella package) only - */ - const firebaseExpVersion = new Map(); - firebaseExpVersion.set( - FIREBASE_UMBRELLA_PACKAGE_NAME, - versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME) - ); - const firebaseExpPath = packagePaths.filter(p => - p.includes(FIREBASE_UMBRELLA_PACKAGE_NAME) - ); - await resetWorkingTreeAndBumpVersions(firebaseExpPath, firebaseExpVersion); - - /** - * push to github - */ - await commitAndPush(versions); + // */ + // await publishToNpm(packagePaths); + + // /** + // * reset the working tree to recover package names with -exp in the package.json files, + // * then bump patch version of firebase-exp (the umbrella package) only + // */ + // const firebaseExpVersion = new Map(); + // firebaseExpVersion.set( + // FIREBASE_UMBRELLA_PACKAGE_NAME, + // versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME) + // ); + // const firebaseExpPath = packagePaths.filter(p => + // p.includes(FIREBASE_UMBRELLA_PACKAGE_NAME) + // ); + // await resetWorkingTreeAndBumpVersions(firebaseExpPath, firebaseExpVersion); + + // /** + // * push to github + // */ + // await commitAndPush(versions); } catch (err) { /** * Log any errors that happened during the process From c3c12883ab7286b036593dcf9dbef6bc428becca Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 10:01:02 -0700 Subject: [PATCH 2/7] release compat packages experimentally --- scripts/exp/release.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/exp/release.ts b/scripts/exp/release.ts index ba1372b285f..04a6a7a8662 100644 --- a/scripts/exp/release.ts +++ b/scripts/exp/release.ts @@ -138,7 +138,14 @@ async function buildPackages() { // Build exp packages except for firebase-exp await spawn( 'yarn', - ['lerna', 'run', '--scope', '@firebase/*-exp', 'build:release'], + [ + 'lerna', + 'run', + '--scope', + '@firebase/*-exp', + '@firebase/*-compat', + 'build:release' + ], { cwd: projectRoot, stdio: 'inherit' From 848d4f47d69267d5eb800b12cca28914c872368c Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 10:09:22 -0700 Subject: [PATCH 3/7] correct command --- scripts/exp/release.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/exp/release.ts b/scripts/exp/release.ts index 04a6a7a8662..aef064fa564 100644 --- a/scripts/exp/release.ts +++ b/scripts/exp/release.ts @@ -143,6 +143,7 @@ async function buildPackages() { 'run', '--scope', '@firebase/*-exp', + '--scope', '@firebase/*-compat', 'build:release' ], From 4feb2f3357f117a841777c8d41d1c7daf7eb20f9 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 10:25:25 -0700 Subject: [PATCH 4/7] build compat --- scripts/exp/release.ts | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/scripts/exp/release.ts b/scripts/exp/release.ts index aef064fa564..fc1b0a997b6 100644 --- a/scripts/exp/release.ts +++ b/scripts/exp/release.ts @@ -138,15 +138,7 @@ async function buildPackages() { // Build exp packages except for firebase-exp await spawn( 'yarn', - [ - 'lerna', - 'run', - '--scope', - '@firebase/*-exp', - '--scope', - '@firebase/*-compat', - 'build:release' - ], + ['lerna', 'run', '--scope', '@firebase/*-exp', 'build:release'], { cwd: projectRoot, stdio: 'inherit' @@ -164,6 +156,16 @@ async function buildPackages() { } ); + // Build compat packages + await spawn( + 'yarn', + ['lerna', 'run', '--scope', '@firebase/*-compat', 'build'], + { + cwd: projectRoot, + stdio: 'inherit' + } + ); + // Build firebase-exp await spawn( 'yarn', From cf42dec503d5d418e9c33a2e6de7b4330e58e771 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 10:36:40 -0700 Subject: [PATCH 5/7] do not abort on error --- packages-exp/app-compat/rollup.config.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages-exp/app-compat/rollup.config.js b/packages-exp/app-compat/rollup.config.js index 0a84c8c7b19..3e1a34e37d6 100644 --- a/packages-exp/app-compat/rollup.config.js +++ b/packages-exp/app-compat/rollup.config.js @@ -29,7 +29,8 @@ const deps = Object.keys( */ const es5BuildPlugins = [ typescriptPlugin({ - typescript + typescript, + abortOnError: false }), json() ]; From 9e8c12649f3f30aab7c4dc974aed22db2a48b08f Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 11:08:58 -0700 Subject: [PATCH 6/7] fix --- packages-exp/app-compat/rollup.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages-exp/app-compat/rollup.config.js b/packages-exp/app-compat/rollup.config.js index 3e1a34e37d6..a6d5bc60993 100644 --- a/packages-exp/app-compat/rollup.config.js +++ b/packages-exp/app-compat/rollup.config.js @@ -63,6 +63,7 @@ const es5Builds = [ const es2017BuildPlugins = [ typescriptPlugin({ typescript, + abortOnError: false, tsconfigOverride: { compilerOptions: { target: 'es2017' From 89c9be6ec8541f3fe0d580f006e9eb64d266a063 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Thu, 27 Aug 2020 11:20:31 -0700 Subject: [PATCH 7/7] Revert "test" This reverts commit 40bd2421bed3c0346b3a06da9b4e295bbc6c7f41. --- scripts/exp/release.ts | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/scripts/exp/release.ts b/scripts/exp/release.ts index fc1b0a997b6..35aefdbcfb1 100644 --- a/scripts/exp/release.ts +++ b/scripts/exp/release.ts @@ -69,27 +69,27 @@ async function publishExpPackages() { /** * Release packages to NPM - // */ - // await publishToNpm(packagePaths); - - // /** - // * reset the working tree to recover package names with -exp in the package.json files, - // * then bump patch version of firebase-exp (the umbrella package) only - // */ - // const firebaseExpVersion = new Map(); - // firebaseExpVersion.set( - // FIREBASE_UMBRELLA_PACKAGE_NAME, - // versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME) - // ); - // const firebaseExpPath = packagePaths.filter(p => - // p.includes(FIREBASE_UMBRELLA_PACKAGE_NAME) - // ); - // await resetWorkingTreeAndBumpVersions(firebaseExpPath, firebaseExpVersion); - - // /** - // * push to github - // */ - // await commitAndPush(versions); + */ + await publishToNpm(packagePaths); + + /** + * reset the working tree to recover package names with -exp in the package.json files, + * then bump patch version of firebase-exp (the umbrella package) only + */ + const firebaseExpVersion = new Map(); + firebaseExpVersion.set( + FIREBASE_UMBRELLA_PACKAGE_NAME, + versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME) + ); + const firebaseExpPath = packagePaths.filter(p => + p.includes(FIREBASE_UMBRELLA_PACKAGE_NAME) + ); + await resetWorkingTreeAndBumpVersions(firebaseExpPath, firebaseExpVersion); + + /** + * push to github + */ + await commitAndPush(versions); } catch (err) { /** * Log any errors that happened during the process