From a0f465c32255bb88cae60d26d621f7c877bb2984 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 16 Jun 2020 12:28:07 -0700 Subject: [PATCH 1/2] Allow undefined callback functions in Storage Observer --- packages/firebase/index.d.ts | 2 +- packages/storage-types/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts index 93df8ad400f..f5b4a17042c 100644 --- a/packages/firebase/index.d.ts +++ b/packages/firebase/index.d.ts @@ -7579,7 +7579,7 @@ declare namespace firebase.storage { on( event: firebase.storage.TaskEvent, nextOrObserver?: - | firebase.Observer + | Partial> | null | ((a: UploadTaskSnapshot) => any), error?: ((a: Error) => any) | null, diff --git a/packages/storage-types/index.d.ts b/packages/storage-types/index.d.ts index 4aa67a6c8bd..902461581cc 100644 --- a/packages/storage-types/index.d.ts +++ b/packages/storage-types/index.d.ts @@ -91,7 +91,7 @@ export interface UploadTask { on( event: TaskEvent, nextOrObserver?: - | Observer + | Partial> | null | ((a: UploadTaskSnapshot) => any), error?: ((a: Error) => any) | null, From fac628168cf2a1f427f6b716c6bfc38e3aa26fa4 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Thu, 9 Jul 2020 11:27:55 -0700 Subject: [PATCH 2/2] Create popular-cups-melt.md --- .changeset/popular-cups-melt.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/popular-cups-melt.md diff --git a/.changeset/popular-cups-melt.md b/.changeset/popular-cups-melt.md new file mode 100644 index 00000000000..b5b662a6337 --- /dev/null +++ b/.changeset/popular-cups-melt.md @@ -0,0 +1,7 @@ +--- +"firebase": patch +"@firebase/storage-types": patch +"@firebase/storage": patch +--- + +[fix] Updated the TypeScript types for all APIs using Observers to allow callback omission.