From 91bb822228dfdd0df34fce258c6c2465556b1eec Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 2 Jun 2020 17:14:08 -0700 Subject: [PATCH] Add setLogLevel() This adds setLogLevel() to the lite SDK. Note that (at least for now) we don't validate API input, so we don't need to call the wrapper. Discussion on this is still pending. --- packages/firestore/exp/index.d.ts | 18 +++++++++--------- packages/firestore/lite/index.d.ts | 8 +++++++- packages/firestore/lite/index.node.ts | 2 ++ 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/packages/firestore/exp/index.d.ts b/packages/firestore/exp/index.d.ts index 03747f48771..ef9f6b8571a 100644 --- a/packages/firestore/exp/index.d.ts +++ b/packages/firestore/exp/index.d.ts @@ -52,7 +52,13 @@ export interface SnapshotMetadata { isEqual(other: SnapshotMetadata): boolean; } -export type LogLevel = 'debug' | 'error' | 'silent'; +export type LogLevel = + | 'debug' + | 'error' + | 'silent' + | 'warn' + | 'info' + | 'verbose'; export function setLogLevel(logLevel: LogLevel): void; @@ -169,10 +175,7 @@ export class Transaction { get(documentRef: DocumentReference): Promise>; - set( - documentRef: DocumentReference, - data: T, - ): Transaction; + set(documentRef: DocumentReference, data: T): Transaction; set( documentRef: DocumentReference, data: Partial, @@ -193,10 +196,7 @@ export class Transaction { export class WriteBatch { private constructor(); - set( - documentRef: DocumentReference, - data: T, - ): WriteBatch; + set(documentRef: DocumentReference, data: T): WriteBatch; set( documentRef: DocumentReference, data: Partial, diff --git a/packages/firestore/lite/index.d.ts b/packages/firestore/lite/index.d.ts index 8227e41a557..1b0ecbf49b8 100644 --- a/packages/firestore/lite/index.d.ts +++ b/packages/firestore/lite/index.d.ts @@ -33,7 +33,13 @@ export interface Settings { ignoreUndefinedProperties?: boolean; } -export type LogLevel = 'debug' | 'error' | 'silent'; +export type LogLevel = + | 'debug' + | 'error' + | 'silent' + | 'warn' + | 'info' + | 'verbose'; export function setLogLevel(logLevel: LogLevel): void; diff --git a/packages/firestore/lite/index.node.ts b/packages/firestore/lite/index.node.ts index 2e1ba8312fa..7818476a167 100644 --- a/packages/firestore/lite/index.node.ts +++ b/packages/firestore/lite/index.node.ts @@ -38,6 +38,8 @@ export { serverTimestamp } from './src/api/field_value'; +export { setLogLevel } from '../src/util/log'; + export function registerFirestore(): void { _registerComponent( new Component(