From dbfc207d3765623b8fdc95aa2ac6d3f40690bf80 Mon Sep 17 00:00:00 2001 From: Brian Chen Date: Wed, 12 Feb 2020 17:07:38 -0800 Subject: [PATCH 1/2] check for cordova --- .../firestore/src/platform_browser/webchannel_connection.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/firestore/src/platform_browser/webchannel_connection.ts b/packages/firestore/src/platform_browser/webchannel_connection.ts index 48674cc0e84..d8c4be1e8c4 100644 --- a/packages/firestore/src/platform_browser/webchannel_connection.ts +++ b/packages/firestore/src/platform_browser/webchannel_connection.ts @@ -29,6 +29,7 @@ import { isBrowserExtension, isElectron, isIE, + isMobileCordova, isReactNative, isUWP } from '@firebase/util'; @@ -275,6 +276,7 @@ export class WebChannelConnection implements Connection { // known to (sometimes) not include an Origin. See // https://github.com/firebase/firebase-js-sdk/issues/1491. if ( + !isMobileCordova() && !isReactNative() && !isElectron() && !isIE() && From 8f36b70dc7b79ddb01e6aa81b94fe6f132428077 Mon Sep 17 00:00:00 2001 From: Brian Chen Date: Thu, 13 Feb 2020 14:15:36 -0800 Subject: [PATCH 2/2] add changelog --- packages/firestore/CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/firestore/CHANGELOG.md b/packages/firestore/CHANGELOG.md index 0231cea2cd0..7c447808c06 100644 --- a/packages/firestore/CHANGELOG.md +++ b/packages/firestore/CHANGELOG.md @@ -1,8 +1,10 @@ # Unreleased +- [fixed] Fixed an issue where auth credentials were not respected in Cordova + environments (#2626). - [fixed] Fixed a performance regression introduced by the addition of `Query.limitToLast(n: number)` in Firestore 1.7.0 (Firebase 7.3.0) (#2620). - [fixed] Fixed an issue where `CollectionReference.add()` would reject - custom types when using `withConverter()`. (#2606) + custom types when using `withConverter()` (#2606). # 1.9.3 - [fixed] Fixed an issue where auth credentials were not respected in some