From 033b8073310baa657780b4119d3830a154eccf6c Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Tue, 13 Aug 2019 13:52:26 -0700 Subject: [PATCH 1/3] remove firebase/app and firebase/app-types from peerDependencies --- packages/database-types/package.json | 1 - packages/database/package.json | 2 -- 2 files changed, 3 deletions(-) diff --git a/packages/database-types/package.json b/packages/database-types/package.json index 6c70791c32a..d96f7f4ee78 100644 --- a/packages/database-types/package.json +++ b/packages/database-types/package.json @@ -11,7 +11,6 @@ "index.d.ts" ], "peerDependencies": { - "@firebase/app-types": "0.x" }, "repository": { "directory": "packages/database-types", diff --git a/packages/database/package.json b/packages/database/package.json index 569b20ec2a9..a0fda81a12c 100644 --- a/packages/database/package.json +++ b/packages/database/package.json @@ -22,8 +22,6 @@ }, "license": "Apache-2.0", "peerDependencies": { - "@firebase/app": "0.x", - "@firebase/app-types": "0.x" }, "dependencies": { "@firebase/database-types": "0.4.2", From 2a37043608a307c029931a0226ca2cb14b02abde Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Tue, 13 Aug 2019 17:14:02 -0700 Subject: [PATCH 2/3] make app-types a regular dependency to make admin sdk happy --- packages/database-types/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/database-types/package.json b/packages/database-types/package.json index d96f7f4ee78..0c40b9ff8e8 100644 --- a/packages/database-types/package.json +++ b/packages/database-types/package.json @@ -10,7 +10,8 @@ "files": [ "index.d.ts" ], - "peerDependencies": { + "dependencies": { + "@firebase/app-types": "0.x" }, "repository": { "directory": "packages/database-types", From e1d64c8e782889dc3aa53cbec51ef6d5e77bd8c7 Mon Sep 17 00:00:00 2001 From: Feiyang1 Date: Tue, 13 Aug 2019 17:22:37 -0700 Subject: [PATCH 3/3] demote @firebase/app and app-types to devDeps --- packages/database/package.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/database/package.json b/packages/database/package.json index a0fda81a12c..97789770ad6 100644 --- a/packages/database/package.json +++ b/packages/database/package.json @@ -31,6 +31,8 @@ "tslib": "1.10.0" }, "devDependencies": { + "@firebase/app": "0.x", + "@firebase/app-types": "0.x", "@types/chai": "4.1.7", "@types/mocha": "5.2.7", "@types/node": "11.13.18",