From 24e3ad11bf7ca67949423318fe6e52acc6a8cfd4 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Fri, 21 Jun 2019 16:34:59 -0700 Subject: [PATCH 1/3] Don't store document with 0 version in Spec Test --- packages/firestore/test/unit/specs/listen_spec.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/test/unit/specs/listen_spec.test.ts b/packages/firestore/test/unit/specs/listen_spec.test.ts index be1c7d107a3..7c7fcf435af 100644 --- a/packages/firestore/test/unit/specs/listen_spec.test.ts +++ b/packages/firestore/test/unit/specs/listen_spec.test.ts @@ -102,7 +102,7 @@ describeSpec('Listens:', [], () => { specTest("Doesn't raise 'hasPendingWrites' for deletes", [], () => { const query1 = Query.atPath(path('collection')); - const docA = doc('collection/a', 0, { key: 'a' }); + const docA = doc('collection/a', 1000, { key: 'a' }); return spec() .userListens(query1) From 33bf2c4740c4ee2415ec5b7672b1d7e739386965 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Fri, 21 Jun 2019 16:39:35 -0700 Subject: [PATCH 2/3] Fix one more test --- packages/firestore/test/unit/specs/orderby_spec.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firestore/test/unit/specs/orderby_spec.test.ts b/packages/firestore/test/unit/specs/orderby_spec.test.ts index aef45a89c4c..35144c779df 100644 --- a/packages/firestore/test/unit/specs/orderby_spec.test.ts +++ b/packages/firestore/test/unit/specs/orderby_spec.test.ts @@ -62,7 +62,7 @@ describeSpec('OrderBy:', [], () => { const query = Query.atPath(path('collection')).addOrderBy( orderBy('sort', 'asc') ); - const docA = doc('collection/a', 0, { key: 'a', sort: 2 }); + const docA = doc('collection/a', 1000, { key: 'a', sort: 2 }); const docB = doc('collection/b', 1001, { key: 'b', sort: 1 }); return spec() From f70eb9b23e44b0e21bdd991932d055793d3cb6b1 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Fri, 21 Jun 2019 17:04:25 -0700 Subject: [PATCH 3/3] Use proper versions --- packages/firestore/test/unit/specs/orderby_spec.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/firestore/test/unit/specs/orderby_spec.test.ts b/packages/firestore/test/unit/specs/orderby_spec.test.ts index 35144c779df..62a639614bb 100644 --- a/packages/firestore/test/unit/specs/orderby_spec.test.ts +++ b/packages/firestore/test/unit/specs/orderby_spec.test.ts @@ -68,13 +68,13 @@ describeSpec('OrderBy:', [], () => { return spec() .withGCEnabled(false) .userListens(query) - .watchAcksFull(query, 1000, docA, docB) + .watchAcksFull(query, 1002, docA, docB) .expectEvents(query, { added: [docB, docA] }) .userUnlistens(query) .watchRemoves(query) - .userListens(query, 'resume-token-1000') + .userListens(query, 'resume-token-1002') .expectEvents(query, { added: [docB, docA], fromCache: true }) - .watchAcksFull(query, 1000) + .watchAcksFull(query, 1002) .expectEvents(query, {}); }); });