From bae5f1e17b528601e70b5b94644ef01dfc856586 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Sat, 18 Aug 2018 10:46:13 -0700 Subject: [PATCH 1/2] Support BrowserPlatforms with no window or document --- .../src/platform_browser/browser_platform.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/firestore/src/platform_browser/browser_platform.ts b/packages/firestore/src/platform_browser/browser_platform.ts index b3ee09a939a..1d8896374c4 100644 --- a/packages/firestore/src/platform_browser/browser_platform.ts +++ b/packages/firestore/src/platform_browser/browser_platform.ts @@ -27,14 +27,18 @@ export class BrowserPlatform implements Platform { readonly emptyByteString = ''; - readonly document = document; - - readonly window = window; - constructor() { this.base64Available = typeof atob !== 'undefined'; } + get document(): Document | null { + return typeof document !== 'undefined' ? document : null; + } + + get window(): Window | null { + return typeof window !== 'undefined' ? window : null; + } + loadConnection(databaseInfo: DatabaseInfo): Promise { return Promise.resolve(new WebChannelConnection(databaseInfo)); } From 922e73f566b3c9e3fd5f8b6d6a7ba703954675a5 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Mon, 20 Aug 2018 09:05:18 -0700 Subject: [PATCH 2/2] Add Changelog entry for ReactNative fix --- packages/firestore/CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/firestore/CHANGELOG.md b/packages/firestore/CHANGELOG.md index 2a268b804aa..9c64a3d523b 100644 --- a/packages/firestore/CHANGELOG.md +++ b/packages/firestore/CHANGELOG.md @@ -1,4 +1,8 @@ -# 0.7.0 (Unreleased) +# Unreleased +- [fixed] Fixed a regression that prevented use of Firestore on ReactNative's + Expo platform (#1138). + +# 0.7.0 - [fixed] Fixed `get({source: 'cache'})` to be able to return nonexistent documents from cache. - [changed] Prepared the persistence layer to allow shared access from multiple