Skip to content

5.0.4 Typescript definitions are broken #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swftvsn opened this issue May 30, 2018 · 2 comments
Closed

5.0.4 Typescript definitions are broken #882

swftvsn opened this issue May 30, 2018 · 2 comments
Assignees

Comments

@swftvsn
Copy link

swftvsn commented May 30, 2018

[REQUIRED] Describe your environment

  • Operating System version: High Sierra
  • Firebase SDK version: 5.0.0, 5.0.1, 5.0.2, 5.0.3, 5.0.4
  • Firebase Product: firestore, auth

[REQUIRED] Describe the problem

Can't compile typescript project.

Steps to reproduce:

Update to any of the 5.x.x series and you can't compile anymore.. This problem has been discussed in #767

Relevant Code:

import { SomeClass } from '@firebase/firestore-types'

results in

ERROR in ./src/app/service/some/some.service.ts
Module not found: Error: Can't resolve '@firebase/firestore-types' in '/Users/someuser/git/someproject/src/app/service/some'

Repro here:
https://github.com/pyoner/vue-firebase-plugin
run: npm run test
here travis job result https://travis-ci.org/pyoner/vue-firebase-plugin/jobs/382075803

@mikelehen
Copy link
Contributor

Josh, could you by chance take a look at this and #767 and provide guidance?

@jshcrowthe
Copy link
Contributor

I'm closing this as a duplicate of #767 response will be there. I think have an idea of what is going on.

@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants