fetch is not a function

[sharpcoder77]

Describe your environment

• Operating System version: Ubuntu 14.04.02
• Firebase SDK version: 4.1.3
• Firebase Product: messaging

Describe the problem

Firebase messaging doesn't work with latest npm package. It throws:

TypeError: fetch is not a function
    at WindowController.manifestCheck_ (window-controller.js?:149)
    at WindowController.getToken (window-controller.js?:125)

Exact line in code is here

Steps to reproduce:

Install latest firebase package from npm. Follow tutorial given here.

Relevant Code:

      firebase.initializeApp(opts);
      const messaging = firebase.messaging();
      messaging.requestPermission()
        .then(function() {
          console.log('Notification permission granted.');
          return messaging.getToken()
            .then((currentToken) => {
              if (currentToken) {
                console.log("Token is: " + currentToken)
              } else {
                // you don't have permission to show notifications
                // detect whether they are blocked or not, then show your custom UI
              }
            })
            .catch((err) => {
              console.log("Error to get token is: " + err);
              // retrieving token failed, analyze the error
            });
        })
        .catch(function(err) {
          console.log('Unable to get permission to notify.', err);
        });

[google-oss-bot]

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

[jsayol]

It seems like there should be a check for the Fetch API here.

Either that, or use a polyfill like this one maybe?

[jshcrowthe]

@skstronghold On which browser are you seeing this behavior? Messaging only supports browsers that support service worker (see https://firebase.google.com/docs/cloud-messaging/js/client) so I'd be curious if this isn't a browser issue.

That said, @jsayol is probably right that we should add that check.

[gauntface]

The SDK should perform an additional check here:

firebase-js-sdk/src/messaging/controllers/window-controller.ts

Line 360 in c054dab

isSupported_() {

[jshcrowthe]

We have merged #79 at it will go out in the next release. Thanks for the issue @skstronghold!