-
Notifications
You must be signed in to change notification settings - Fork 937
Auth uses soon to be deprecated apis.google.com/js/api.js #7012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for raising this! We use Only the Google Sign In functionality is deprecated. The full list of deprecated methods are here: https://developers.google.com/identity/oauth2/web/guides/migration-to-gis#library_quick_reference |
@prameshj Thanks for your reply. Notice that
but it seems is a fallback option. Is |
Thanks for pointing it out! cc @maneesht since this is on Firestore. I think since it is not mentioned in https://developers.google.com/identity/oauth2/web/guides/migration-to-gis#library_quick_reference, this will continue to work. |
The google migration documentation only mentions |
Hi @milaGGL any thoughts / news on this? You need help? |
I got a notice emailed to me the other day:
Does anyone know if this refers to the Firebase JS SDK? I don't think we use Google Sign-in directly anywhere, we only use it via Firebase Auth. Is there a minimum version of the Firebase SDK that we need to upgrade to? |
Hi @nahuelmap, thank you so much for offering help. It turns out one of our other firebase product will be effected by this deprecation, and we have alerted them on time, thanks to your ticket. As for our JS SDK, we are working on the safe removal of the gapi.auth. I will keep the thread updated. |
Hi @keeth, gapi auth in JS SDK is only used as a fallback option for first party authentication, and it should only effect our internal usage. Based on the Firebase JavaScript SDK Release Notes, there is no Firebase JS SDK upgrading required regarding this matter. |
@milaGGL I don't see a reference to gapi in the release notes you mentioned, but I'll take your word for it! |
@keeth, sorry for the confusion. I meant since there are no firebase release note on any products, stating that changes are made due to the gapi.auth deprecation, there is no upgrading required regarding this matter. |
Thanks for your work @milaGGL ! When we will get a release with this fix applied? |
@nahuelmap, with pleasure. 😊 |
The removal of @nahuelmap, once again, thank you for bringing this to our attention. |
Google will be deprecating his "Google Sign-In Javascript Platform library" to his new "Identity Services for the Web" on March 31, 2023, as stated in:
https://developers.google.com/identity/gsi/web/guides/migration
https://developers.google.com/identity/oauth2/web/guides/migration-to-gis
The first link says
apis.google.com/js/api.js
is going to be deprecated. This library seems to be used byfirebase-sdk-js
, see:firebase-js-sdk/packages/auth/src/platform_browser/iframe/gapi.ts
Line 107 in b6c231a
So it seems
firebase-sdk-js
uses the old version and is not ready for the incoming deprecation (correct me if I'm wrong) . There are upgrade plans / an schedule for them in the horizon?The text was updated successfully, but these errors were encountered: