onMessage payload click_action and icon not received because propagateNotificationPayload

[rockmandash]

[REQUIRED] Describe your environment

• Operating System version: macOS 12.0.1
• Browser version: Chrome 96
• Firebase SDK version: 9.6.1
• Firebase Product: cloud messaging

[REQUIRED] Describe the problem

This function removes click_action and icon when onMessage is called by foreground app.

firebase-js-sdk/packages/messaging/src/helpers/externalizePayload.ts

Lines 39 to 63 in 8d415c6

	function propagateNotificationPayload(
	payload: MessagePayload,
	messagePayloadInternal: MessagePayloadInternal
	): void {
	if (!messagePayloadInternal.notification) {
	return;
	}
	payload.notification = {};
	const title = messagePayloadInternal.notification!.title;
	if (!!title) {
	payload.notification!.title = title;
	}
	const body = messagePayloadInternal.notification!.body;
	if (!!body) {
	payload.notification!.body = body;
	}
	const image = messagePayloadInternal.notification!.image;
	if (!!image) {
	payload.notification!.image = image;
	}
	}

And the image is not supported on macOS 12, which makes the code very confusing.

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[zwu52]

@rockmandash I assume you are sending through the legacy send API since click_action and icon has been deprecated after v1 Send. I can make a PR to fill them in.

[rockmandash]

@zwu52 I did not utilize a legacy API, thus my payload is as follows:

{
  "message": {
    "token": "",
    "notification": {
      "title": "",
      "body": ""
    },
    "webpush": {
      "fcm_options": {
        "link": ""
      },
      "notification": {
        "icon": ""
      }
    }
  }
}

The FCM backend formats the webpush.fcm_options.link to click_action automatically.

For firebase-messaging-sw.js, my payload works normally in background mode without doing anything.

However, when it comes to foreground messages, these two payloads are lost, which is why I created this issue.

[guiiamorim]

I'm also having this issue, I cant see any of the fcm_options on the event handlers provided by the sdk. For the link to appear I have to make my own notificationclick event handler on the service worker:

Also, if I add an event listener on the push event I can retrieve the click_action parsing the event data to json. Someone found a solution for this?

[guimap]

@guiiamorim the code

works for you ? For me, this event never reach, because this code
https://github.com/firebase/firebase-js-sdk/blob/master/packages/messaging/src/listeners/sw-listeners.ts#L121

[DellaBitta]

It looks like an attempted fix was merged in. Could you check to see if it fixes this issue? Thanks!

[google-oss-bot]

Hey @rockmandash. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

[google-oss-bot]

Since there haven't been any recent updates here, I am going to close this issue.

@rockmandash if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.