When use the realtime database in Deno, it never finishes running

[ayame113]

[REQUIRED] Describe your environment

• Operating System version: Microsoft Windows [Version 10.0.19042.1348]
• Browser version: Deno 1.16.3
• Firebase SDK version: 9.6.0
• Firebase Product: realtime database

[REQUIRED] Describe the problem

Steps to reproduce:

Running the following code with deno run -A --location http://foo.com test.ts will hang forever after the finish is outputted, even though I'm calling deleteApp.

// test.ts

// @deno-types="https://cdn.esm.sh/v58/[email protected]/app/dist/app/index.d.ts"
import { deleteApp, FirebaseOptions, initializeApp } from "https://www.gstatic.com/firebasejs/9.6.0/firebase-app.js";
// @deno-types="https://cdn.esm.sh/v58/[email protected]/database/dist/database/index.d.ts"
import { getDatabase, ref, set } from "https://www.gstatic.com/firebasejs/9.6.0/firebase-database.js";

const app = initializeApp({...});
const db = getDatabase(app);
await set(ref(db), 1);
deleteApp(app);
console.log("finish");

I changed it to log the setTimeout call using the following code and found that setTimeout called the reportStats_ method forever.

const originalSetTimeout = globalThis.setTimeout;
globalThis.setTimeout = (...args) => {
  const timeoutId = originalSetTimeout(...args);
  console.log({ timeoutId }, ...args);
  return timeoutId;
};

The reason for this may be that the implementation of setTimeout in Deno is web compatible and there is no unref method.
We probably need to stop using the unref method and call crearTimeout() when deleteApp() is called.

firebase-js-sdk/packages/database/src/core/util/util.ts

Lines 620 to 625 in cdada6c

	const timeout: number | object = setTimeout(fn, time);
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	if (typeof timeout === 'object' && (timeout as any)['unref']) {
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	(timeout as any)['unref']();
	}

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[jbalidiong]

Hi @ayame113, thanks for the report. I was able to reproduce the behavior. Let me check what we can do for this issue or bring someone here that can provide more context about it. I’ll update this thread if I have any information to share.

[maneesht]

@ayame113 - we use unref to signal to the runtime that if the program wishes to exit earlier, do not wait on this setTimeout to finish. If we just clear the timeout right then and there, the stats will never get reported.

I have an experimental PR created that uses Deno's unrefTimer as opposed to NodeJS's unref. It's experimental since the API that it requires Deno.unrefTimer is considered an "unstable" API, and in order for this to work, you need to run your app with --unstable to allow for unstable APIs to be used.

[maneesht]

Also, thank you for spending the time to root cause this issue. You made this very easy to debug and test.

[maneesht]

@ayame113 - I have another PR incoming to allow you to use Deno with local node module dependencies, if you choose. But this issue has been resolved.

[ayame113]

But this issue has been resolved.

nice!!
thank you!!