Skip to content

Bug still exists: Stop using const enums in the public API #5012 #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Obiwarn opened this issue Sep 7, 2021 · 1 comment · Fixed by #5460
Closed

Bug still exists: Stop using const enums in the public API #5012 #5451

Obiwarn opened this issue Sep 7, 2021 · 1 comment · Fixed by #5460
Labels
api: auth v9

Comments

@Obiwarn
Copy link

Obiwarn commented Sep 7, 2021

I installed firebase 9.0.1.

I use Vite.

On build I still get these errors in node_modules/@firebase/auth/dist/auth-public.d.ts:704:6 which should have been fixed by #5012

node_modules/@firebase/auth/dist/auth-public.d.ts:710:6 - error TS2748: Cannot access ambient const enums when the '--isol
atedModules' flag is provided.

Am I missing something?
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@Feiyang1 Feiyang1 mentioned this issue Sep 8, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth v9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Auth internal types from the public typings firebase/firebase-js-sdk
3 participants
@Obiwarn @google-oss-bot @jbalidiong