8.6.8 breaks Timestamp support for Firestore Emulator #5047

jirizavadil · 2021-06-18T10:12:11Z

Operating System version: MacOS 11.4
Browser version: Google Chrome 91.0.4472.106 (Official Build) (x86_64)
Firebase SDK version: 8.6.8
Firebase tools version: 9.13.1
Firebase Product: firestore

Steps to reproduce:

update firebase to 8.6.8
use firestore emulator
write/read from firestore
XHRs pending for 45s and then get cancelled

I've spent over 3 hours trying to replicate this in a new project, but unsuccessfuly. In the current project i could only try emulators, not cloud environment, as i only have production cloud env at this time.

Last version that doesn't introduce any bugs for me is 8.4.0

looptheloop88 · 2021-06-21T15:41:43Z

Hi @jirizavadil, thanks for the report. I tried replicating the issue, but I wasn't able to. I used the same SDK version and Firebase tools, but the test app was able to read and write data from Firestore database.

If I can replicate the issue, I can have a better look into it. Please share a minimal, but complete sample of a project that I can run locally. Also, you may enable Firestore debugging firebase.firestore.setLogLevel("debug"); and share with us the logs.

mandalornl · 2021-06-22T13:41:49Z

I think I may have the same issue, but I've managed to isolate the problem. It seems Timestamp is being the culprit here, when using it during a DocumentReference update and in conjuction with the Firestore emulator. At least in my case.

Just follow README.md in the sample code below.

https://github.com/mandalornl/firebase-8.6.8-test

I hope this helps!

jsakas · 2021-06-24T19:48:30Z

I spend most of my day yesterday trying to debug an issue which I believe might be related to this. In my case, using snap.ref.update() was updating the local db, but failing to update the emulated DB. Using database.doc().update() seemed to work fine. Spent hours trying to debug and create a repro unsuccessfully. Downgrading to v8.6.1 for now.

google-oss-bot · 2021-07-01T01:02:03Z

Hey @jirizavadil. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

mandalornl · 2021-07-02T08:58:35Z

I think I may have the same issue, but I've managed to isolate the problem. [...]

I would like to add that it's broken from >= 8.6.3 and not related to 8.6.8 only.

Also notice the difference between the timestampValue values:

Firebase <= 8.6.2

{
  "update": {
    "name": "projects/sometest-78e8d/databases/(default)/documents/test/CBVTnjvUzfraWgCuuynB",
    "fields": {
      "updatedAt": {
        "timestampValue": "2021-07-02T07:24:58.654000000Z"
      }
    }
  },
  "updateMask": {
    "fieldPaths": [
      "updatedAt"
    ]
  },
  "currentDocument": {
    "exists": true
  }
}

Firebase >= 8.6.3

{
  "update": {
    "name": "projects/sometest-78e8d/databases/(default)/documents/test/eUikl3S7Bt6d4AxTq0aS",
    "fields": {
      "updatedAt": {
        "timestampValue": {
          "seconds": 1625210353,
          "nanos": 166000000
        }
      }
    }
  },
  "updateMask": {
    "fieldPaths": [
      "updatedAt"
    ]
  },
  "currentDocument": {
    "exists": true
  }
}

jirizavadil · 2021-07-07T10:50:17Z

@looptheloop88 here it is. Thanks to @mandalornl, i've been able to boil it down to a reproducible sample:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>Welcome to Firebase Hosting</title>

    <script defer src="/__/firebase/8.7.0/firebase-app.js"></script>
    <script defer src="/__/firebase/8.7.0/firebase-firestore.js"></script>
    <script defer src="/__/firebase/init.js?useEmulator=true"></script>
  </head>
  <body>
    <script>
      document.addEventListener("DOMContentLoaded", async function () {

        let db = firebase.firestore()
        db.useEmulator("localhost", 8432)

        var laRef = db.collection("cities").doc("LA")

        await laRef.set({
          created: new Date()
        })

        // WORKS
        await laRef.update({
          tralala1: true,
          updated1: firebase.firestore.FieldValue.serverTimestamp()
        })

        // DOES NOTHING
        await laRef.update({
          tralala2: true,
          updated2: new Date()
        })
      })
    </script>
  </body>
</html>

I've tested many versions with this result:
works: 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.6.0, 8.6.1, 8.6.2
broken: 8.6.3, 8.6.4, 8.6.5, 8.6.7, 8.6.8, 8.7.0

looptheloop88 · 2021-07-08T14:55:45Z

Hi @jirizavadil and @mandalornl, I was able to replicate the issue using the sample projects that you've shared with us. Let me bring this matter to the attention of our engineers here.

schmidt-sebastian · 2021-07-13T22:30:23Z

This broke with #4933, since the call here converts the timestamp to JSON (it should be a string).

Will be fixed next week.

silviokucz · 2021-07-28T18:10:28Z

This issue is still happening. Using the emulator, when I try changing the data in a timestamp field, it seems like the change took but when I refresh the page it still shows the old timestamp. No entries in the log!
I have firebase version 9.16.0

schmidt-sebastian · 2021-07-28T18:30:14Z

Do you have persistence enabled? I wonder if these documents are read from cache.

You should be able to see logs from the Firestore SDK itself (call firebase.firestore.setLogLevel('debug')).

silviokucz · 2021-07-28T18:39:03Z

This is how I start the emulator:
"npm run build:watch && firebase emulators:start --inspect-functions --export-on-exit c:\tmp\firebase --import c:\tmp\firebase"

Is there a way to set the log level using the CLI?

schmidt-sebastian · 2021-07-28T18:40:20Z

No - this would be a line you need to add to your Web or Node app.

silviokucz · 2021-07-28T19:11:05Z

Well, I'm not sure how to do that on the functions side, is there an example?
where do i import firebase from?

I have this but doesn't compile:.
import * as functions from 'firebase-functions'
...
functions.firestore.setLogLevel('debug')

(should be easy for you to try on your end, do you experience the same problem?)

silviokucz · 2021-07-28T20:34:26Z

Update:
I was able to set debug level using this flag:
firebase --debug emulators:start --inspect-functions --export-on-exit c:\tmp\firebase --import c:\tmp\firebase
I see a lot of logs starting with [debug]
Unfortunately working with the firestore emulator and editing values doesn't generate any entries.

schmidt-sebastian · 2021-07-29T03:07:54Z

Are you writing to Firestore from your function? You may have to invoke the Admin SDK directly. If you can send me a code snippet, I can modify it to enable logging.

mandalornl · 2021-07-29T06:45:51Z

This issue is still happening. Using the emulator, when I try changing the data in a timestamp field, it seems like the change took but when I refresh the page it still shows the old timestamp. No entries in the log!
I have firebase version 9.16.0

I want to confirm that this happens when you try to add or update a Timestamp field from an existing Document using the Firebase Emulator Suite web interface on localhost:4000. This also happend before the update in versions > 8.6.2 and < 8.8.0.

silviokucz · 2021-07-29T15:49:19Z

Confirmed. Using the emulator served on localhost:4000. Changing the value of a timestamp field fails silently.

schmidt-sebastian · 2021-07-29T16:27:41Z

I was able to write Timestamps from the Web SDK, the Node Web SDK and the Node Admin SDK successfully.

Here is my setup: https://gist.github.com/schmidt-sebastian/59c76a6655b3556d542b90882de689bc

Can you spot a difference?

silviokucz · 2021-07-29T16:49:13Z

Thanks for sharing the code. Writing and reading timestamp fields using the SDK is not the issue, maybe I didn't explain well on the original post.
The issue occurs when using the emulator web UI manually.

schmidt-sebastian · 2021-07-29T16:53:03Z

Ah, okay, that makes sense. Will get this fixed.

yuchenshi · 2021-08-11T21:11:06Z

Fixed in Emulator UI in Firebase CLI v9.16.1.

google-oss-bot added the api: firestore label Jun 18, 2021

looptheloop88 added the testing-sdk testing with emulator label Jun 18, 2021

looptheloop88 added the needs-info label Jun 21, 2021

google-oss-bot added the no-recent-activity label Jul 1, 2021

google-oss-bot removed the no-recent-activity label Jul 2, 2021

google-oss-bot added needs-attention and removed needs-info labels Jul 7, 2021

looptheloop88 added bug and removed needs-attention labels Jul 8, 2021

dconeybe self-assigned this Jul 8, 2021

schmidt-sebastian mentioned this issue Jul 13, 2021

Firestore emulator is rejecting timestamp field firebase/firebase-tools#3553

Closed

schmidt-sebastian assigned schmidt-sebastian and unassigned dconeybe Jul 13, 2021

schmidt-sebastian changed the title ~~8.6.8 breaks all network requests to firestore~~ 8.6.8 breaks all network requests to firestore emulator Jul 13, 2021

schmidt-sebastian changed the title ~~8.6.8 breaks all network requests to firestore emulator~~ 8.6.8 breaks Timestamp support for Firestore Emulator Jul 13, 2021

schmidt-sebastian mentioned this issue Jul 14, 2021

Don't normalize Proto data during deepClone #5147

Merged

schmidt-sebastian closed this as completed in #5147 Jul 15, 2021

google-oss-bot mentioned this issue Jul 20, 2021

Version Packages #5177

Merged

schmidt-sebastian reopened this Jul 29, 2021

schmidt-sebastian assigned dannhauser and unassigned schmidt-sebastian Jul 29, 2021

yuchenshi mentioned this issue Jul 29, 2021

Timestamp not updating on Emulator UI firebase/firebase-tools-ui#617

Closed

yuchenshi closed this as completed Aug 11, 2021

firebase locked and limited conversation to collaborators Sep 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8.6.8 breaks Timestamp support for Firestore Emulator #5047

8.6.8 breaks Timestamp support for Firestore Emulator #5047

jirizavadil commented Jun 18, 2021

looptheloop88 commented Jun 21, 2021

mandalornl commented Jun 22, 2021

jsakas commented Jun 24, 2021

google-oss-bot commented Jul 1, 2021

mandalornl commented Jul 2, 2021

jirizavadil commented Jul 7, 2021

looptheloop88 commented Jul 8, 2021

schmidt-sebastian commented Jul 13, 2021

silviokucz commented Jul 28, 2021 •

edited

Loading

schmidt-sebastian commented Jul 28, 2021

silviokucz commented Jul 28, 2021

schmidt-sebastian commented Jul 28, 2021

silviokucz commented Jul 28, 2021

silviokucz commented Jul 28, 2021

schmidt-sebastian commented Jul 29, 2021

mandalornl commented Jul 29, 2021

silviokucz commented Jul 29, 2021

schmidt-sebastian commented Jul 29, 2021

silviokucz commented Jul 29, 2021

schmidt-sebastian commented Jul 29, 2021

yuchenshi commented Aug 11, 2021

8.6.8 breaks Timestamp support for Firestore Emulator #5047

8.6.8 breaks Timestamp support for Firestore Emulator #5047

Comments

jirizavadil commented Jun 18, 2021

Steps to reproduce:

looptheloop88 commented Jun 21, 2021

mandalornl commented Jun 22, 2021

jsakas commented Jun 24, 2021

google-oss-bot commented Jul 1, 2021

mandalornl commented Jul 2, 2021

jirizavadil commented Jul 7, 2021

looptheloop88 commented Jul 8, 2021

schmidt-sebastian commented Jul 13, 2021

silviokucz commented Jul 28, 2021 • edited Loading

schmidt-sebastian commented Jul 28, 2021

silviokucz commented Jul 28, 2021

schmidt-sebastian commented Jul 28, 2021

silviokucz commented Jul 28, 2021

silviokucz commented Jul 28, 2021

schmidt-sebastian commented Jul 29, 2021

mandalornl commented Jul 29, 2021

silviokucz commented Jul 29, 2021

schmidt-sebastian commented Jul 29, 2021

silviokucz commented Jul 29, 2021

schmidt-sebastian commented Jul 29, 2021

yuchenshi commented Aug 11, 2021

silviokucz commented Jul 28, 2021 •

edited

Loading