Skip to content

@firebase/xyz namespaced packages on npmjs/yarnpkg do not link to GitHub #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jthegedus opened this issue Jan 8, 2018 · 1 comment · Fixed by #416
Closed

@firebase/xyz namespaced packages on npmjs/yarnpkg do not link to GitHub #415

jthegedus opened this issue Jan 8, 2018 · 1 comment · Fixed by #416
Assignees
@jshcrowthe
Labels
api: auth api: core

Comments

@jthegedus
Copy link

jthegedus commented Jan 8, 2018 •
edited
Loading

[REQUIRED] Describe your environment

  • Operating System version: Ubuntu 17.04
  • Firebase SDK version: @firebase/auth v0.3.1
  • Firebase Product: auth

[REQUIRED] Describe the problem

@firebase/util links to GitHub on yarnpkg.com and npmjs.com

@firebase/auth does not. Additionally, the owner field for @firebase/auth is not 'Firebase' but rather jshcrowthe, which after an investigation is revealed to be a significant contributor, which is fine. These two things in combination will cause people to flinch when glancing for the repo and contributor.
@jshcrowthe jshcrowthe mentioned this issue Jan 8, 2018
Merged
@jshcrowthe
Copy link
Contributor

Hey @jthegedus thanks for the issue! I have added an author field and fixed the repo field for @firebase/auth in #416

@jshcrowthe jshcrowthe self-assigned this Jan 8, 2018
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jshcrowthe jshcrowthe

Labels
api: auth api: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

package.json Fixes firebase/firebase-js-sdk
4 participants
@jshcrowthe @bojeil-google @jthegedus @google-oss-bot