You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on this PR I came across several inconsistencies with the typings across @firebase/database and @firebase/database-typing. For example, there are multiple cases where unknown is used in-place of any.
In an ideal world, there is Database from @firebase/database implementing FirebaseDatabase from @firebase/database-types, this would ensure that the two are compatible with one another.
I intend to use the type FirebaseDatabase as an interface for Database instances but it isn't possible in TS right now. I attempted the change myself but it got involved after a point because differences span a bit more than just replacing unknown to any once the Query class gets involved.
Thanks!
The text was updated successfully, but these errors were encountered:
While working on this PR I came across several inconsistencies with the typings across
@firebase/database
and@firebase/database-typing
. For example, there are multiple cases whereunknown
is used in-place ofany
.In an ideal world, there is
Database
from@firebase/database
implementingFirebaseDatabase
from@firebase/database-types
, this would ensure that the two are compatible with one another.I intend to use the type
FirebaseDatabase
as an interface forDatabase
instances but it isn't possible in TS right now. I attempted the change myself but it got involved after a point because differences span a bit more than just replacingunknown
toany
once theQuery
class gets involved.Thanks!
The text was updated successfully, but these errors were encountered: