Skip to content

Commit fde2314

Browse files
author
Brian Chen
authored
Disable use of $httpHeaders in Cordova (#2626)
1 parent 2af214a commit fde2314

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/firestore/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
# Unreleased
2+
- [fixed] Fixed an issue where auth credentials were not respected in Cordova
3+
environments (#2626).
24
- [fixed] Fixed a performance regression introduced by the addition of
35
`Query.limitToLast(n: number)` in Firestore 1.7.0 (Firebase 7.3.0) (#2620).
46
- [fixed] Fixed an issue where `CollectionReference.add()` would reject
5-
custom types when using `withConverter()`. (#2606)
7+
custom types when using `withConverter()` (#2606).
68

79
# 1.9.3
810
- [fixed] Fixed an issue where auth credentials were not respected in some

packages/firestore/src/platform_browser/webchannel_connection.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import {
2929
isBrowserExtension,
3030
isElectron,
3131
isIE,
32+
isMobileCordova,
3233
isReactNative,
3334
isUWP
3435
} from '@firebase/util';
@@ -275,6 +276,7 @@ export class WebChannelConnection implements Connection {
275276
// known to (sometimes) not include an Origin. See
276277
// https://github.com/firebase/firebase-js-sdk/issues/1491.
277278
if (
279+
!isMobileCordova() &&
278280
!isReactNative() &&
279281
!isElectron() &&
280282
!isIE() &&

0 commit comments

Comments
 (0)