PR Feedback

Author: avolkovi

packages-exp/auth-exp/src/model/action_code_url.test.ts renamed to packages-exp/auth-exp/src/core/action_code_url.test.ts

@@ -18,7 +18,7 @@
 import { expect } from 'chai';
 import { ActionCodeURL } from './action_code_url';
 import { mockAuth } from '../../test/mock_auth';
-import { Operation } from './action_code_info';
+import { Operation } from '../model/action_code_info';
 
 describe('ActionCodeURL', () => {
   describe('_fromLink', () => {

packages-exp/auth-exp/src/model/action_code_url.ts renamed to packages-exp/auth-exp/src/core/action_code_url.ts

@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-import { AuthErrorCode, AUTH_ERROR_FACTORY } from '../core/errors';
-import { Operation } from './action_code_info';
-import { Auth } from './auth';
+import { AuthErrorCode, AUTH_ERROR_FACTORY } from './errors';
+import { Operation } from '../model/action_code_info';
+import { Auth } from '../model/auth';
 
 /**
  * Enums for fields in URL query string.
@@ -35,7 +35,7 @@ enum QueryField {
 /**
  * Map from mode string in action code URL to Action Code Info operation.
  */
-const ModeToOperationMap: { [key: string]: Operation } = {
+const MODE_TO_OPERATION_MAP: { [key: string]: Operation } = {
   'recoverEmail': Operation.RECOVER_EMAIL,
   'resetPassword': Operation.PASSWORD_RESET,
   'signIn': Operation.EMAIL_SIGNIN,
@@ -48,7 +48,7 @@ const ModeToOperationMap: { [key: string]: Operation } = {
  * Maps the mode string in action code URL to Action Code Info operation.
  */
 function parseMode(mode: string | null): Operation | null {
-  return mode ? ModeToOperationMap[mode] || null : null;
+  return mode ? MODE_TO_OPERATION_MAP[mode] || null : null;
 }
 
 function parseDeepLink(url: string): string {

packages-exp/auth-exp/src/core/strategies/email_link.ts

@@ -21,7 +21,7 @@ import {
   ActionCodeSettings,
   setActionCodeSettingsOnRequest
 } from '../../model/action_code_settings';
-import { ActionCodeURL } from '../../model/action_code_url';
+import { ActionCodeURL } from '../action_code_url';
 import { Auth } from '../../model/auth';
 
 export async function sendSignInLinkToEmail(