Skip to content

Commit faa05bd

Browse files
committed
added Promise existence check before every test of requiredApisAvailable
1 parent dc23631 commit faa05bd

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

packages/performance/src/services/api_service.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ describe('Firebase Performance > api_service', () => {
5555
});
5656
describe('requiredApisAvailable', () => {
5757
it('call logger when fetch is not available', () => {
58+
expect(window.Promise).to.exist;
5859
stub(consoleLogger, 'info');
5960
stub(window, 'fetch').value(null);
6061
return api.requiredApisAvailable().then(isAvailable => {
@@ -63,6 +64,7 @@ describe('Firebase Performance > api_service', () => {
6364
});
6465
});
6566
it('call logger when navigator is not available', () => {
67+
expect(window.Promise).to.exist;
6668
stub(consoleLogger, 'info');
6769
stub(window, 'fetch').returns(Promise.resolve(new Response('{}')));
6870
stub(api, 'navigator').value(null);
@@ -72,6 +74,7 @@ describe('Firebase Performance > api_service', () => {
7274
});
7375
});
7476
it('call logger when cookie is not enabled', () => {
77+
expect(window.Promise).to.exist;
7578
stub(consoleLogger, 'info');
7679
stub(window, 'fetch').returns(Promise.resolve(new Response('{}')));
7780
stub(api.navigator, 'cookieEnabled').value(false);
@@ -82,6 +85,7 @@ describe('Firebase Performance > api_service', () => {
8285
});
8386

8487
it('call logger when isIndexedDBAvailable returns false', () => {
88+
expect(window.Promise).to.exist;
8589
stub(consoleLogger, 'info');
8690
stub(window, 'fetch').returns(Promise.resolve(new Response('{}')));
8791
stub(FirebaseUtil, 'isIndexedDBAvailable').returns(false);
@@ -92,6 +96,7 @@ describe('Firebase Performance > api_service', () => {
9296
});
9397

9498
it('call logger when validateIndexedDBOpenable throws an exception', () => {
99+
expect(window.Promise).to.exist;
95100
stub(consoleLogger, 'info');
96101
stub(window, 'fetch').returns(Promise.resolve(new Response('{}')));
97102
stub(FirebaseUtil, 'isIndexedDBAvailable').returns(true);
@@ -102,12 +107,14 @@ describe('Firebase Performance > api_service', () => {
102107
});
103108
});
104109
it('logger not called when function returns true', () => {
110+
expect(window.Promise).to.exist;
105111
stub(consoleLogger, 'info');
106112
stub(window, 'fetch').returns(Promise.resolve(new Response('{}')));
107113
stub(FirebaseUtil, 'isIndexedDBAvailable').returns(true);
108114
stub(FirebaseUtil, 'validateIndexedDBOpenable').returns(
109115
Promise.resolve(true)
110116
);
117+
111118
return api.requiredApisAvailable().then(isAvailable => {
112119
expect(consoleLogger.info).to.not.be.called;
113120
expect(isAvailable).to.be.true;

0 commit comments

Comments
 (0)