Merge remote-tracking branch 'origin/master' into ss-fork-testing

Author: samtstern

.changeset/calm-apes-collect.md

@@ -1,5 +1,5 @@
 ---
-"@firebase/firebase": patch
+"firebase": patch
 "@firebase/analytics": patch 
 ---
 

.changeset/spicy-masks-sort.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Fixed a bug that caused slow retries for IndexedDB operations even when a webpage re-entered the foreground.

.changeset/thirty-flies-flow.md

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "@babel/core": "7.11.0",
     "@babel/preset-env": "7.11.0",
     "browserify": "16.5.1",

.changeset/tidy-elephants-beam.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "typescript": "3.9.7"
   }
 }

integration/browserify/package.json

@@ -15,7 +15,7 @@
   },
   "peerDependencies": {
     "@firebase/app": "0.x",
-    "@firebase/firestore": "1.16.2"
+    "@firebase/firestore": "1.16.3"
   },
   "devDependencies": {
     "@types/mocha": "7.0.2",

integration/firebase-typings/package.json

@@ -8,7 +8,7 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "chai": "4.2.0",
     "chromedriver": "84.0.1",
     "express": "4.17.1",

integration/firestore/package.json

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "@babel/core": "7.11.0",
     "@babel/preset-env": "7.11.0",
     "@types/chai": "4.2.12",

integration/messaging/package.json

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "@babel/core": "7.11.0",
     "@babel/preset-env": "7.11.0",
     "chai": "4.2.0",

integration/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-exp",
-  "version": "0.800.3",
+  "version": "0.800.4",
   "private": true,
   "description": "Firebase JavaScript library for web and Node.js",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
@@ -37,7 +37,7 @@
   "dependencies": {
     "@firebase/app-exp": "0.0.800",
     "@firebase/functions-exp": "0.0.800",
-    "@firebase/firestore": "1.16.2"
+    "@firebase/firestore": "1.16.3"
   },
   "devDependencies": {
     "rollup": "2.23.0",

integration/webpack/package.json

@@ -0,0 +1,8 @@
+# @firebase/database-types
+
+## 0.5.2
+### Patch Changes
+
+
+
+- [`ef348fed`](https://github.com/firebase/firebase-js-sdk/commit/ef348fed291338351706a697cbb9fb17a9d06ff4) [#3511](https://github.com/firebase/firebase-js-sdk/pull/3511)  - Added interface `Database` which is implemented by `FirebaseDatabase`. This allows consumer SDKs (such as the Firebase Admin SDK) to export the database types as an interface.

packages-exp/firebase-exp/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/database-types",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "@firebase/database Types",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "license": "Apache-2.0",

packages/database-types/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Unreleased
 
+## 0.6.10
+
+### Patch Changes
+
+- [`ef348fed`](https://github.com/firebase/firebase-js-sdk/commit/ef348fed291338351706a697cbb9fb17a9d06ff4) [#3511](https://github.com/firebase/firebase-js-sdk/pull/3511) - Added interface `Database` which is implemented by `FirebaseDatabase`. This allows consumer SDKs (such as the Firebase Admin SDK) to export the database types as an interface.
+
+- Updated dependencies [[`ef348fed`](https://github.com/firebase/firebase-js-sdk/commit/ef348fed291338351706a697cbb9fb17a9d06ff4)]:
+  - @firebase/database-types@0.5.2
+
 ## 0.6.9
 
 ### Patch Changes

packages/database-types/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/database",
-  "version": "0.6.9",
+  "version": "0.6.10",
   "description": "",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.node.cjs.js",
@@ -25,7 +25,7 @@
   "license": "Apache-2.0",
   "peerDependencies": {},
   "dependencies": {
-    "@firebase/database-types": "0.5.1",
+    "@firebase/database-types": "0.5.2",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "0.3.0",
     "@firebase/component": "0.1.17",

packages/database/CHANGELOG.md

@@ -1,5 +1,13 @@
 # firebase
 
+## 7.17.2
+
+### Patch Changes
+
+- Updated dependencies [[`ef348fed`](https://github.com/firebase/firebase-js-sdk/commit/ef348fed291338351706a697cbb9fb17a9d06ff4)]:
+  - @firebase/database@0.6.10
+  - @firebase/firestore@1.16.3
+
 ## 7.17.1
 
 ### Patch Changes

packages/database/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase",
-  "version": "7.17.1",
+  "version": "7.17.2",
   "description": "Firebase JavaScript library for web and Node.js",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "license": "Apache-2.0",
@@ -48,8 +48,8 @@
     "@firebase/app": "0.6.9",
     "@firebase/app-types": "0.6.1",
     "@firebase/auth": "0.14.9",
-    "@firebase/database": "0.6.9",
-    "@firebase/firestore": "1.16.2",
+    "@firebase/database": "0.6.10",
+    "@firebase/firestore": "1.16.3",
     "@firebase/functions": "0.4.49",
     "@firebase/installations": "0.4.15",
     "@firebase/messaging": "0.6.21",

packages/firebase/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @firebase/firestore
 
+## 1.16.3
+
+### Patch Changes
+
+- Updated dependencies [[`7f0860a4`](https://github.com/firebase/firebase-js-sdk/commit/7f0860a4ced76da8492ae44d2267a2f1cc58eccb)]:
+  - @firebase/webchannel-wrapper@0.3.0
+
 ## 1.16.2
 
 ### Patch Changes

packages/firebase/package.json

@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-import './register';
+import { registerFirestore } from './register';
+
+registerFirestore();
 
 export { FieldPath, documentId } from '../lite/src/api/field_path';
 

packages/firestore/CHANGELOG.md

@@ -37,5 +37,3 @@ export function registerFirestore(): void {
   );
   registerVersion('firestore-exp', version, 'node');
 }
-
-registerFirestore();

packages/firestore/exp/index.ts

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
-import '../register';
-
+import { registerFirestore } from '../register';
+registerFirestore();
 /**
  * This will include all of the test files and compile them as needed
  *

packages/firestore/exp/register.ts

@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-import './register';
+import { registerFirestore } from './register';
+
+registerFirestore();
 
 export {
   Firestore as FirebaseFirestore,

packages/firestore/exp/test/bootstrap.ts

@@ -37,5 +37,3 @@ export function registerFirestore(): void {
   );
   registerVersion('firestore-lite', version, 'node');
 }
-
-registerFirestore();

packages/firestore/lite/index.ts

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
-import '../register';
-
+import { registerFirestore } from '../register';
+registerFirestore();
 /**
  * This will include all of the test files and compile them as needed
  *

packages/firestore/lite/register.ts

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/firestore",
-  "version": "1.16.2",
+  "version": "1.16.3",
   "engines": {
     "node": "^8.13.0 || >=10.10.0"
   },
@@ -60,7 +60,7 @@
     "@firebase/firestore-types": "1.12.0",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "0.3.0",
-    "@firebase/webchannel-wrapper": "0.2.41",
+    "@firebase/webchannel-wrapper": "0.3.0",
     "@grpc/grpc-js": "^1.0.0",
     "@grpc/proto-loader": "^0.5.0",
     "node-fetch": "2.6.0",

packages/firestore/lite/test/bootstrap.ts

@@ -294,8 +294,8 @@ export class IndexedDbPersistence implements Persistence {
     debugAssert(!this.started, 'IndexedDbPersistence double-started!');
     debugAssert(this.window !== null, "Expected 'window' to be defined");
 
-    // NOTE: This is expected to fail sometimes (in the case of another tab 
-    // already having the persistence lock), so it's the first thing we should 
+    // NOTE: This is expected to fail sometimes (in the case of another tab
+    // already having the persistence lock), so it's the first thing we should
     // do.
     return this.updateClientMetadataAndTryBecomePrimary()
       .then(() => {

packages/firestore/package.json

@@ -21,7 +21,7 @@ import { logDebug, logError } from './log';
 import { Deferred } from './promise';
 import { ExponentialBackoff } from '../remote/backoff';
 import { isIndexedDbTransactionError } from '../local/simple_db';
-import { getWindow } from '../platform/dom';
+import { getDocument } from '../platform/dom';
 
 const LOG_TAG = 'AsyncQueue';
 
@@ -235,12 +235,22 @@ export class AsyncQueue {
   // Visibility handler that triggers an immediate retry of all retryable
   // operations. Meant to speed up recovery when we regain file system access
   // after page comes into foreground.
-  private visibilityHandler = (): void => this.backoff.skipBackoff();
+  private visibilityHandler: () => void = () => {
+    const document = getDocument();
+    if (document) {
+      logDebug(
+        LOG_TAG,
+        'Visibility state changed to  ',
+        document.visibilityState
+      );
+    }
+    this.backoff.skipBackoff();
+  };
 
   constructor() {
-    const window = getWindow();
-    if (window && typeof window.addEventListener === 'function') {
-      window.addEventListener('visibilitychange', this.visibilityHandler);
+    const document = getDocument();
+    if (document && typeof document.addEventListener === 'function') {
+      document.addEventListener('visibilitychange', this.visibilityHandler);
     }
   }
 
@@ -293,9 +303,12 @@ export class AsyncQueue {
     this.verifyNotFailed();
     if (!this._isShuttingDown) {
       this._isShuttingDown = true;
-      const window = getWindow();
-      if (window) {
-        window.removeEventListener('visibilitychange', this.visibilityHandler);
+      const document = getDocument();
+      if (document && typeof document.removeEventListener === 'function') {
+        document.removeEventListener(
+          'visibilitychange',
+          this.visibilityHandler
+        );
       }
       await this.enqueueEvenAfterShutdown(op);
     }

packages/firestore/src/local/indexeddb_persistence.ts

@@ -1,5 +1,12 @@
 # @firebase/testing
 
+## 0.20.10
+
+### Patch Changes
+
+- Updated dependencies []:
+  - [email protected]
+
 ## 0.20.9
 
 ### Patch Changes

packages/firestore/src/util/async_queue.ts

@@ -21,7 +21,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "firebase": "7.17.1",
+    "firebase": "7.17.2",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "0.3.0",
     "request": "2.88.2"

packages/rules-unit-testing/CHANGELOG.md

@@ -0,0 +1,10 @@
+# @firebase/webchannel-wrapper
+
+## 0.3.0
+### Minor Changes
+
+
+
+- [`7f0860a4`](https://github.com/firebase/firebase-js-sdk/commit/7f0860a4ced76da8492ae44d2267a2f1cc58eccb) [#3372](https://github.com/firebase/firebase-js-sdk/pull/3372)  - Upgrade to the latest version of Google Closure Library and Compiler. This dependency will be
+  necessary for future updates to the @firebase/firestore package. Developers will not need to
+  make any changes to their code to handle this change.

packages/rules-unit-testing/package.json

@@ -1,14 +1,12 @@
 {
   "name": "@firebase/webchannel-wrapper",
-  "version": "0.2.41",
+  "version": "0.3.0",
   "description": "A wrapper of the webchannel packages from closure-library for use outside of a closure compiled application",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.js",
   "module": "dist/index.esm.js",
   "esm2017": "dist/index.esm2017.js",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "dev": "watch 'yarn build' src",
     "build": "gulp",