Skip to content

Commit f8c4ea9

Browse files
hsubox76hsubox76
committed
Fix original analytics
1 parent ec9b8a9 commit f8c4ea9

File tree

3 files changed

+49
-42
lines changed

3 files changed

+49
-42
lines changed

‎packages/analytics-types/index.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export interface FirebaseAnalytics {
6767
*/
6868
logEvent(
6969
eventName: 'add_shipping_info',
70-
eventParams: {
70+
eventParams?: {
7171
coupon?: EventParams['coupon'];
7272
currency?: EventParams['currency'];
7373
items?: EventParams['items'];
@@ -88,7 +88,7 @@ export interface FirebaseAnalytics {
8888
*/
8989
logEvent(
9090
eventName: 'add_to_cart' | 'add_to_wishlist' | 'remove_from_cart',
91-
eventParams: {
91+
eventParams?: {
9292
currency?: EventParams['currency'];
9393
value?: EventParams['value'];
9494
items?: EventParams['items'];
@@ -107,7 +107,7 @@ export interface FirebaseAnalytics {
107107
*/
108108
logEvent(
109109
eventName: 'begin_checkout',
110-
eventParams: {
110+
eventParams?: {
111111
currency?: EventParams['currency'];
112112
coupon?: EventParams['coupon'];
113113
value?: EventParams['value'];
@@ -127,7 +127,7 @@ export interface FirebaseAnalytics {
127127
*/
128128
logEvent(
129129
eventName: 'checkout_progress',
130-
eventParams: {
130+
eventParams?: {
131131
currency?: EventParams['currency'];
132132
coupon?: EventParams['coupon'];
133133
value?: EventParams['value'];
@@ -149,7 +149,7 @@ export interface FirebaseAnalytics {
149149
*/
150150
logEvent(
151151
eventName: 'exception',
152-
eventParams: {
152+
eventParams?: {
153153
description?: EventParams['description'];
154154
fatal?: EventParams['fatal'];
155155
[key: string]: any;
@@ -167,7 +167,7 @@ export interface FirebaseAnalytics {
167167
*/
168168
logEvent(
169169
eventName: 'generate_lead',
170-
eventParams: {
170+
eventParams?: {
171171
value?: EventParams['value'];
172172
currency?: EventParams['currency'];
173173
transaction_id?: EventParams['transaction_id'];
@@ -186,7 +186,7 @@ export interface FirebaseAnalytics {
186186
*/
187187
logEvent(
188188
eventName: 'login',
189-
eventParams: {
189+
eventParams?: {
190190
method?: EventParams['method'];
191191
[key: string]: any;
192192
},
@@ -203,7 +203,7 @@ export interface FirebaseAnalytics {
203203
*/
204204
logEvent(
205205
eventName: 'page_view',
206-
eventParams: {
206+
eventParams?: {
207207
page_title?: string;
208208
page_location?: string;
209209
page_path?: string;
@@ -222,7 +222,7 @@ export interface FirebaseAnalytics {
222222
*/
223223
logEvent(
224224
eventName: 'purchase' | 'refund',
225-
eventParams: {
225+
eventParams?: {
226226
value?: EventParams['value'];
227227
currency?: EventParams['currency'];
228228
transaction_id: EventParams['transaction_id'];
@@ -246,7 +246,7 @@ export interface FirebaseAnalytics {
246246
*/
247247
logEvent(
248248
eventName: 'screen_view',
249-
eventParams: {
249+
eventParams?: {
250250
app_name: string;
251251
screen_name: EventParams['screen_name'];
252252
app_id?: string;
@@ -267,7 +267,7 @@ export interface FirebaseAnalytics {
267267
*/
268268
logEvent(
269269
eventName: 'search' | 'view_search_results',
270-
eventParams: {
270+
eventParams?: {
271271
search_term?: EventParams['search_term'];
272272
[key: string]: any;
273273
},
@@ -284,7 +284,7 @@ export interface FirebaseAnalytics {
284284
*/
285285
logEvent(
286286
eventName: 'select_content',
287-
eventParams: {
287+
eventParams?: {
288288
items?: EventParams['items'];
289289
promotions?: EventParams['promotions'];
290290
content_type?: EventParams['content_type'];
@@ -304,7 +304,7 @@ export interface FirebaseAnalytics {
304304
*/
305305
logEvent(
306306
eventName: 'select_item',
307-
eventParams: {
307+
eventParams?: {
308308
items?: EventParams['items'];
309309
item_list_name?: EventParams['item_list_name'];
310310
item_list_id?: EventParams['item_list_id'];
@@ -323,7 +323,7 @@ export interface FirebaseAnalytics {
323323
*/
324324
logEvent(
325325
eventName: 'select_promotion' | 'view_promotion',
326-
eventParams: {
326+
eventParams?: {
327327
items?: EventParams['items'];
328328
promotion_id?: EventParams['promotion_id'];
329329
promotion_name?: EventParams['promotion_name'];
@@ -342,7 +342,7 @@ export interface FirebaseAnalytics {
342342
*/
343343
logEvent(
344344
eventName: 'set_checkout_option',
345-
eventParams: {
345+
eventParams?: {
346346
checkout_step?: EventParams['checkout_step'];
347347
checkout_option?: EventParams['checkout_option'];
348348
[key: string]: any;
@@ -360,7 +360,7 @@ export interface FirebaseAnalytics {
360360
*/
361361
logEvent(
362362
eventName: 'share',
363-
eventParams: {
363+
eventParams?: {
364364
method?: EventParams['method'];
365365
content_type?: EventParams['content_type'];
366366
content_id?: EventParams['content_id'];
@@ -379,7 +379,7 @@ export interface FirebaseAnalytics {
379379
*/
380380
logEvent(
381381
eventName: 'sign_up',
382-
eventParams: {
382+
eventParams?: {
383383
method?: EventParams['method'];
384384
[key: string]: any;
385385
},
@@ -396,7 +396,7 @@ export interface FirebaseAnalytics {
396396
*/
397397
logEvent(
398398
eventName: 'timing_complete',
399-
eventParams: {
399+
eventParams?: {
400400
name: string;
401401
value: number;
402402
event_category?: string;
@@ -416,7 +416,7 @@ export interface FirebaseAnalytics {
416416
*/
417417
logEvent(
418418
eventName: 'view_cart' | 'view_item',
419-
eventParams: {
419+
eventParams?: {
420420
currency?: EventParams['currency'];
421421
items?: EventParams['items'];
422422
value?: EventParams['value'];
@@ -435,7 +435,7 @@ export interface FirebaseAnalytics {
435435
*/
436436
logEvent(
437437
eventName: 'view_item_list',
438-
eventParams: {
438+
eventParams?: {
439439
items?: EventParams['items'];
440440
item_list_name?: EventParams['item_list_name'];
441441
item_list_id?: EventParams['item_list_id'];

‎packages/analytics/src/factory.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ import {
2020
Gtag,
2121
SettingsOptions,
2222
DynamicConfig,
23-
MinimalDynamicConfig
23+
MinimalDynamicConfig,
24+
AnalyticsCallOptions,
25+
CustomParams,
26+
EventParams
2427
} from '@firebase/analytics-types';
2528
import {
2629
logEvent,
@@ -226,7 +229,11 @@ export function factory(
226229
app,
227230
// Public methods return void for API simplicity and to better match gtag,
228231
// while internal implementations return promises.
229-
logEvent: (eventName, eventParams, options) => {
232+
logEvent: (
233+
eventName: string,
234+
eventParams?: EventParams | CustomParams,
235+
options?: AnalyticsCallOptions
236+
) => {
230237
logEvent(
231238
wrappedGtagFunction,
232239
initializationPromisesMap[appId],

‎packages/firebase/index.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4479,7 +4479,7 @@ declare namespace firebase.analytics {
44794479
*/
44804480
logEvent(
44814481
eventName: 'add_shipping_info',
4482-
eventParams: {
4482+
eventParams?: {
44834483
coupon?: EventParams['coupon'];
44844484
currency?: EventParams['currency'];
44854485
items?: EventParams['items'];
@@ -4500,7 +4500,7 @@ declare namespace firebase.analytics {
45004500
*/
45014501
logEvent(
45024502
eventName: 'add_to_cart' | 'add_to_wishlist' | 'remove_from_cart',
4503-
eventParams: {
4503+
eventParams?: {
45044504
currency?: EventParams['currency'];
45054505
value?: EventParams['value'];
45064506
items?: EventParams['items'];
@@ -4519,7 +4519,7 @@ declare namespace firebase.analytics {
45194519
*/
45204520
logEvent(
45214521
eventName: 'begin_checkout',
4522-
eventParams: {
4522+
eventParams?: {
45234523
currency?: EventParams['currency'];
45244524
coupon?: EventParams['coupon'];
45254525
value?: EventParams['value'];
@@ -4539,7 +4539,7 @@ declare namespace firebase.analytics {
45394539
*/
45404540
logEvent(
45414541
eventName: 'checkout_progress',
4542-
eventParams: {
4542+
eventParams?: {
45434543
currency?: EventParams['currency'];
45444544
coupon?: EventParams['coupon'];
45454545
value?: EventParams['value'];
@@ -4561,7 +4561,7 @@ declare namespace firebase.analytics {
45614561
*/
45624562
logEvent(
45634563
eventName: 'exception',
4564-
eventParams: {
4564+
eventParams?: {
45654565
description?: EventParams['description'];
45664566
fatal?: EventParams['fatal'];
45674567
[key: string]: any;
@@ -4579,7 +4579,7 @@ declare namespace firebase.analytics {
45794579
*/
45804580
logEvent(
45814581
eventName: 'generate_lead',
4582-
eventParams: {
4582+
eventParams?: {
45834583
value?: EventParams['value'];
45844584
currency?: EventParams['currency'];
45854585
transaction_id?: EventParams['transaction_id'];
@@ -4598,7 +4598,7 @@ declare namespace firebase.analytics {
45984598
*/
45994599
logEvent(
46004600
eventName: 'login',
4601-
eventParams: {
4601+
eventParams?: {
46024602
method?: EventParams['method'];
46034603
[key: string]: any;
46044604
},
@@ -4615,7 +4615,7 @@ declare namespace firebase.analytics {
46154615
*/
46164616
logEvent(
46174617
eventName: 'page_view',
4618-
eventParams: {
4618+
eventParams?: {
46194619
page_title?: string;
46204620
page_location?: string;
46214621
page_path?: string;
@@ -4634,7 +4634,7 @@ declare namespace firebase.analytics {
46344634
*/
46354635
logEvent(
46364636
eventName: 'purchase' | 'refund',
4637-
eventParams: {
4637+
eventParams?: {
46384638
value?: EventParams['value'];
46394639
currency?: EventParams['currency'];
46404640
transaction_id: EventParams['transaction_id'];
@@ -4658,7 +4658,7 @@ declare namespace firebase.analytics {
46584658
*/
46594659
logEvent(
46604660
eventName: 'screen_view',
4661-
eventParams: {
4661+
eventParams?: {
46624662
app_name: string;
46634663
screen_name: EventParams['screen_name'];
46644664
app_id?: string;
@@ -4679,7 +4679,7 @@ declare namespace firebase.analytics {
46794679
*/
46804680
logEvent(
46814681
eventName: 'search' | 'view_search_results',
4682-
eventParams: {
4682+
eventParams?: {
46834683
search_term?: EventParams['search_term'];
46844684
[key: string]: any;
46854685
},
@@ -4696,7 +4696,7 @@ declare namespace firebase.analytics {
46964696
*/
46974697
logEvent(
46984698
eventName: 'select_content',
4699-
eventParams: {
4699+
eventParams?: {
47004700
items?: EventParams['items'];
47014701
promotions?: EventParams['promotions'];
47024702
content_type?: EventParams['content_type'];
@@ -4716,7 +4716,7 @@ declare namespace firebase.analytics {
47164716
*/
47174717
logEvent(
47184718
eventName: 'select_item',
4719-
eventParams: {
4719+
eventParams?: {
47204720
items?: EventParams['items'];
47214721
item_list_name?: EventParams['item_list_name'];
47224722
item_list_id?: EventParams['item_list_id'];
@@ -4735,7 +4735,7 @@ declare namespace firebase.analytics {
47354735
*/
47364736
logEvent(
47374737
eventName: 'select_promotion' | 'view_promotion',
4738-
eventParams: {
4738+
eventParams?: {
47394739
items?: EventParams['items'];
47404740
promotion_id?: EventParams['promotion_id'];
47414741
promotion_name?: EventParams['promotion_name'];
@@ -4754,7 +4754,7 @@ declare namespace firebase.analytics {
47544754
*/
47554755
logEvent(
47564756
eventName: 'set_checkout_option',
4757-
eventParams: {
4757+
eventParams?: {
47584758
checkout_step?: EventParams['checkout_step'];
47594759
checkout_option?: EventParams['checkout_option'];
47604760
[key: string]: any;
@@ -4772,7 +4772,7 @@ declare namespace firebase.analytics {
47724772
*/
47734773
logEvent(
47744774
eventName: 'share',
4775-
eventParams: {
4775+
eventParams?: {
47764776
method?: EventParams['method'];
47774777
content_type?: EventParams['content_type'];
47784778
content_id?: EventParams['content_id'];
@@ -4791,7 +4791,7 @@ declare namespace firebase.analytics {
47914791
*/
47924792
logEvent(
47934793
eventName: 'sign_up',
4794-
eventParams: {
4794+
eventParams?: {
47954795
method?: EventParams['method'];
47964796
[key: string]: any;
47974797
},
@@ -4808,7 +4808,7 @@ declare namespace firebase.analytics {
48084808
*/
48094809
logEvent(
48104810
eventName: 'timing_complete',
4811-
eventParams: {
4811+
eventParams?: {
48124812
name: string;
48134813
value: number;
48144814
event_category?: string;
@@ -4828,7 +4828,7 @@ declare namespace firebase.analytics {
48284828
*/
48294829
logEvent(
48304830
eventName: 'view_cart' | 'view_item',
4831-
eventParams: {
4831+
eventParams?: {
48324832
currency?: EventParams['currency'];
48334833
items?: EventParams['items'];
48344834
value?: EventParams['value'];
@@ -4847,7 +4847,7 @@ declare namespace firebase.analytics {
48474847
*/
48484848
logEvent(
48494849
eventName: 'view_item_list',
4850-
eventParams: {
4850+
eventParams?: {
48514851
items?: EventParams['items'];
48524852
item_list_name?: EventParams['item_list_name'];
48534853
item_list_id?: EventParams['item_list_id'];

0 commit comments

Comments
 (0)