Messaging rewrite (#2484)

Author: mmermerkaya

config/.eslintrc.js

@@ -14,8 +14,9 @@ module.exports = {
   },
   'overrides': [
     {
-      'files': ['**/*.test.ts', '**/test/**/*.ts'],
+      'files': ['**/*.test.ts', '**/{test,testing}/**/*.ts'],
       'rules': {
+        // TODO: Use https://www.npmjs.com/package/eslint-plugin-chai-friendly instead
         'no-unused-expressions': 'off',
         '@typescript-eslint/no-explicit-any': 'off'
       }

config/webpack.test.js

@@ -50,7 +50,7 @@ module.exports = {
           options: { esModules: true }
         },
         enforce: 'post',
-        include: path.resolve(process.cwd(), 'src')
+        exclude: [/\.test\.ts$/, /\btest(ing)?\//]
       },
       {
         test: /\.js$/,

packages/messaging-types/index.d.ts

@@ -24,8 +24,9 @@ import {
   CompleteFn
 } from '@firebase/util';
 
-export class FirebaseMessaging {
-  private constructor();
+export interface FirebaseMessaging {
+  // TODO: remove the token parameter and just delete the token that matches
+  // this app if it exists.
   deleteToken(token: string): Promise<boolean>;
   getToken(): Promise<string>;
   onMessage(

packages/messaging/karma.conf.js

@@ -19,18 +19,17 @@ const karma = require('karma');
 const path = require('path');
 const karmaBase = require('../../config/karma.base');
 
-const files = [`test/**/*.ts`];
+const FILES = [`src/**/*.test.ts`];
 
 module.exports = function(config) {
-  const karmaConfig = Object.assign({}, karmaBase, {
-    // files to load into karma
-    files: files,
-    // frameworks to use
-    // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
+  const karmaConfig = {
+    ...karmaBase,
+    files: FILES,
+    preprocessors: { 'src/**/*.test.ts': ['webpack', 'sourcemap'] },
     frameworks: ['mocha']
-  });
+  };
 
   config.set(karmaConfig);
 };
 
-module.exports.files = files;
+module.exports.files = FILES;

packages/messaging/package.json

@@ -30,11 +30,13 @@
     "@firebase/messaging-types": "0.4.0",
     "@firebase/util": "0.2.36",
     "@firebase/component": "0.1.1",
+    "idb": "3.0.2",
     "tslib": "1.10.0"
   },
   "devDependencies": {
     "rollup": "1.28.0",
     "rollup-plugin-typescript2": "0.25.3",
+    "ts-essentials": "4.0.0",
     "typescript": "3.7.3"
   },
   "repository": {

packages/messaging/rollup.config.js

@@ -36,7 +36,7 @@ const es5BuildPlugins = [
 
 const es5Builds = [
   {
-    input: 'index.ts',
+    input: 'src/index.ts',
     output: [
       { file: pkg.main, format: 'cjs', sourcemap: true },
       { file: pkg.module, format: 'es', sourcemap: true }
@@ -63,7 +63,7 @@ const es2017BuildPlugins = [
 
 const es2017Builds = [
   {
-    input: 'index.ts',
+    input: 'src/index.ts',
     output: {
       file: pkg.esm2017,
       format: 'es',