Fix tests

Author: schmidt-sebastian

packages/storage/.run/All Tests.run.xml

@@ -16,4 +16,4 @@
     <test-pattern>test/{,!(browser)/**/}*.test.ts</test-pattern>
     <method v="2" />
   </configuration>
-</component>
+</component>

packages/storage/src/platform/base64.ts

@@ -23,3 +23,8 @@ const platform = require(`./${process.env.TEST_PLATFORM ?? 'node'}/base64`);
 export function decodeBase64(encoded: string): string {
   return platform.decodeBase64(encoded);
 }
+
+/** Converts a Uint8Array to a string. */
+export function decodeUint8Array(data: Uint8Array): string {
+  return platform.decodeUint8Array(data);
+}

packages/storage/src/platform/browser/base64.ts

@@ -19,3 +19,7 @@
 export function decodeBase64(encoded: string): string {
   return atob(encoded);
 }
+
+export function decodeUint8Array(data: Uint8Array): string {
+  return new TextDecoder().decode(data);
+}

packages/storage/src/platform/node/base64.ts

@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import { TextDecoder } from 'util';
 import { invalidFormat } from '../../implementation/error';
 
 /** Converts a Base64 encoded string to a binary string. */
@@ -24,5 +25,9 @@ export function decodeBase64(encoded: string): string {
   if (/[^-A-Za-z0-9+/=]/.test(encoded)) {
     throw invalidFormat('base64', 'Invalid character found');
   }
-  return new Buffer(encoded, 'base64').toString('binary');
+  return Buffer.from(encoded, 'base64').toString('binary');
+}
+
+export function decodeUint8Array(data: Uint8Array): string {
+  return new TextDecoder().decode(data);
 }

packages/storage/test/unit/reference.exp.test.ts

@@ -38,6 +38,7 @@ import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
 import { Provider } from '@firebase/component';
 import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
 import { fakeServerHandler, storageServiceWithHandler } from './testshared';
+import { decodeUint8Array } from '../../src/platform/base64';
 
 /* eslint-disable @typescript-eslint/no-floating-promises */
 function makeFakeService(
@@ -77,7 +78,7 @@ function withFakeSend(
   ): void {
     let text: Promise<string>;
     if (body instanceof Uint8Array) {
-      text = Promise.resolve(new TextDecoder().decode(body));
+      text = Promise.resolve(decodeUint8Array(body));
     } else {
       text = (body as Blob).text();
     }
@@ -269,11 +270,10 @@ describe('Firebase Storage > Reference', () => {
     getMetadata(ref(reference, 'foo'));
   });
 
-  describe('uploadString', () => {
+  describe.only('uploadString', () => {
     it('Uses metadata.contentType for RAW format', done => {
       // Regression test for b/30989476
       const root = withFakeSend((text: string, headers?: Headers) => {
-        console.log(headers);
         expect(text).to.include('"contentType":"lol/wut"');
       }, done);
       uploadString(ref(root, 'test'), 'hello', StringFormat.RAW, {

packages/storage/test/unit/requests.test.ts

@@ -51,6 +51,7 @@ import {
   CONFIG_STORAGE_BUCKET_KEY
 } from '../../src/implementation/constants';
 import { FirebaseApp } from '@firebase/app-types';
+import { decodeUint8Array } from '../../src/platform/base64';
 
 describe('Firebase Storage > Requests', () => {
   const normalBucket = 'b';
@@ -171,7 +172,7 @@ describe('Firebase Storage > Requests', () => {
         assert.equal(str, expectedStr);
       });
     } else if (body instanceof Uint8Array) {
-      const str = new TextDecoder().decode(body);
+      const str = decodeUint8Array(body);
       assert.equal(str, expectedStr);
     } else {
       assert.equal(body as string, expectedStr);