Remove Multi-Tab TODOs (#1161)

* Remove TODOs that are no longer applicable

* [AUTOMATED]: Prettier Code Styling

Author: schmidt-sebastian

packages/firestore/src/core/sync_engine.ts

@@ -811,7 +811,6 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
     await Promise.all(queriesProcessed);
     this.syncEngineListener!.onWatchChange(newSnaps);
     this.localStore.notifyLocalViewChanges(docChangesInAllViews);
-    // TODO(multitab): Multitab garbage collection
     if (this.isPrimary) {
       await this.localStore
         .collectGarbage()

packages/firestore/src/local/indexeddb_persistence.ts

@@ -907,7 +907,6 @@ export class IndexedDbPersistence implements Persistence {
    */
   private markClientZombied(): void {
     try {
-      // TODO(multitab): Garbage Collect Local Storage
       this.window.localStorage.setItem(
         this.zombiedClientLocalStorageKey(this.clientId),
         String(Date.now())

packages/firestore/src/local/indexeddb_remote_document_cache.ts

@@ -106,7 +106,6 @@ export class IndexedDbRemoteDocumentCache implements RemoteDocumentCache {
       }
 
       if (this.keepDocumentChangeLog) {
-        // TODO(multitab): GC the documentChanges store.
         promises.push(
           documentChangesStore(transaction).put({
             changes: this.serializer.toDbResourcePaths(changedKeys)

packages/firestore/src/local/persistence.ts

@@ -79,9 +79,6 @@ export type PrimaryStateListener = (isPrimary: boolean) => Promise<void>;
  * writes in order to avoid relying on being able to read back uncommitted
  * writes.
  */
-// TODO(multitab): Instead of marking methods as multi-tab safe, we should
-// point out (and maybe enforce) when methods cannot safely be used from
-// secondary tabs.
 export interface Persistence {
   /**
    * Whether or not this persistence instance has been started.

packages/firestore/src/local/shared_client_state.ts

@@ -571,8 +571,6 @@ export class WebStorageSharedClientState implements SharedClientState {
     return !!(platform.window && platform.window.localStorage != null);
   }
 
-  // TOOD(multitab): Register the mutations that are already pending at client
-  // startup.
   async start(): Promise<void> {
     assert(!this.started, 'WebStorageSharedClientState already started');
     assert(
@@ -761,15 +759,15 @@ export class WebStorageSharedClientState implements SharedClientState {
 
   private handleLocalStorageEvent(event: StorageEvent): void {
     if (event.storageArea === this.storage) {
-      // TODO(multitab): This assert will likely become invalid as we add garbage
-      // collection.
-      assert(
-        event.key !== this.localClientStorageKey,
-        'Received LocalStorage notification for local change.'
-      );
-
       debug(LOG_TAG, 'EVENT', event.key, event.newValue);
 
+      if (event.key === this.localClientStorageKey) {
+        error(
+          'Received LocalStorage notification for local change. Another client might have garbage-collected our state'
+        );
+        return;
+      }
+
       this.queue.enqueueAndForget(async () => {
         if (!this.started) {
           this.earlyEvents.push(event);

packages/firestore/test/unit/specs/describe_spec.ts

@@ -45,7 +45,7 @@ const KNOWN_TAGS = [
   DURABLE_PERSISTENCE_TAG
 ];
 
-// TOOD(mrschmidt): Make this configurable with mocha options.
+// TODO(mrschmidt): Make this configurable with mocha options.
 const RUN_BENCHMARK_TESTS = false;
 
 // The format of one describeSpec written to a JSON file.