Skip to content

Commit ed39dfa

Browse files
Update integration tests to use firestore.js (#2508)
This change will allow us to swap out firestore.js for a minified version without having to provide a minified firebase.js
1 parent 885e0b3 commit ed39dfa

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

integration/firestore/gulpfile.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ function copyTests() {
3434
* Therefore these tests and helpers cannot have any src/ dependencies.
3535
*/
3636
const testBase = resolve(__dirname, '../../packages/firestore/test');
37-
const firebaseSdk = resolve(__dirname, '../../packages/firebase/firebase.js');
37+
const firebaseAppSdk = 'firebase/app/dist/index.esm.js';
38+
const firebaseFirestoreSdk = resolve(
39+
__dirname,
40+
'../../packages/firestore/dist/index.esm.js'
41+
);
3842
return gulp
3943
.src(
4044
[
@@ -58,7 +62,8 @@ function copyTests() {
5862
* differences, as well as different paths to a valid firebase_export
5963
*/
6064
/import\s+firebase\s+from\s+('|")[^\1]+firebase_export\1;?/,
61-
`import * as firebase from '${firebaseSdk}';`
65+
`import firebase from '${firebaseAppSdk}';
66+
import '${firebaseFirestoreSdk}';`
6267
)
6368
)
6469
.pipe(

0 commit comments

Comments
 (0)