Skip to content

Commit ebd477d

Browse files
Lint yes - test no
1 parent a7cd38d commit ebd477d

File tree

2 files changed

+2
-21
lines changed

2 files changed

+2
-21
lines changed

packages/firestore/src/api/database.ts

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ export class Transaction
544544
return this;
545545
}
546546

547-
delete(documentRef: PublicDocumentReference<any>): Transaction {
547+
delete(documentRef: PublicDocumentReference<unknown>): Transaction {
548548
const ref = castReference(documentRef);
549549
this._delegate.delete(ref);
550550
return this;
@@ -1866,25 +1866,6 @@ function castReference<T>(
18661866
return cast<ExpDocumentReference<T>>(documentRef, ExpDocumentReference);
18671867
}
18681868

1869-
function validateReference<T>(
1870-
methodName: string,
1871-
documentRef: PublicDocumentReference<T>,
1872-
firestore: Firestore
1873-
): ExpDocumentReference<T> {
1874-
const reference = cast<ExpDocumentReference<T>>(
1875-
documentRef,
1876-
ExpDocumentReference
1877-
);
1878-
if (reference.firestore !== firestore._delegate) {
1879-
throw new FirestoreError(
1880-
Code.INVALID_ARGUMENT,
1881-
'Provided document reference is from a different Firestore instance.'
1882-
);
1883-
} else {
1884-
return reference;
1885-
}
1886-
}
1887-
18881869
/**
18891870
* Converts custom model object of type T into DocumentData by applying the
18901871
* converter if it exists.

packages/firestore/test/integration/api_internal/transaction.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ apiDescribe(
146146
});
147147
});
148148

149-
it('handle reading a doc twice with different versions', () => {
149+
it.only('handle reading a doc twice with different versions', () => {
150150
return integrationHelpers.withTestDb(persistence, db => {
151151
asyncQueue(db).skipDelaysForTimerId(TimerId.TransactionRetry);
152152
const doc = db.collection('counters').doc();

0 commit comments

Comments
 (0)